Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190802132302.13537-1-sashal@kernel.org> <20190802132302.13537-6-sashal@kernel.org>
 <CAJ1xhMWb6OG0xdBtAQZkX-T0XNmMNaMaS=ScJ4ZRwpv9eHXmCQ@mail.gmail.com> <20190803073744.39412f73@coco.lan>
In-Reply-To: <20190803073744.39412f73@coco.lan>
From:   Alexander Kapshuk <alexander.kapshuk@gmail.com>
Date:   Sat, 3 Aug 2019 15:09:38 +0300
Message-ID: <CAJ1xhMV5ub60DSZkHOqE=oKKtBUtGYA6QQxMN-R-79LGr12pQg@mail.gmail.com>
Subject: Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script
 for RHEL/CentOS
To:     Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc:     Sasha Levin <sashal@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "# 3.9+" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Aug 3, 2019 at 1:37 PM Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> wrote:
>
> Em Sat, 3 Aug 2019 13:31:30 +0300
> Alexander Kapshuk <alexander.kapshuk@gmail.com> escreveu:
>
> > > -       if (! $system_release =~ /Fedora/) {
> > > +       if (!($system_release =~ /Fedora/)) {
> > >                 $map{"virtualenv"} = "python-virtualenv";
> > >         }
> >
> > The negated binding operator '!~' could be used here as well, and it
> > does not require the use of extra parenthesis.
> > Just a thought.
>
> Thanks for the tip! Never used such operator. Will start using
> next time we need to handle a pattern like that.
>
> Thanks,
> Mauro

No worries at all.