Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp1217628ybh; Sat, 3 Aug 2019 20:52:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNEl+2+HH4M6eJvEwkLtTFpPsdp0yp2fhOmqz5WyiRLLC6RXNL79AmAVl2yU+59X5NGWan X-Received: by 2002:a17:902:7448:: with SMTP id e8mr138688607plt.85.1564890772027; Sat, 03 Aug 2019 20:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564890772; cv=none; d=google.com; s=arc-20160816; b=GlCik5q/3zr3FntB1/OL4+EKY0Q/p1KEUQp1B+MxJPmwA0JDGXVgycspcthm8O58v4 FHTEkE0kLw+fWuKUp0INuUDuuRhObE1qqGcyk+Wpot1VMENiu85FU7FJYGEyztsKEEWH gPjDJCxit9IkAgm69+j5Ulz8np4ixTCFHeBZt660jpheW5qR6UTVwcdtxX2q5UjNXsgY SPcMwKPGKPIy2zuCuuc5kDt92y4muRVoWLqEC6mmmoPCUJziJc0B7cDy/gt7e0ZKjYz+ fMLdDqEebZGjc7vwiK0fOaqKr1Zpay2IJ7IRw8eI7IqOFEx7Q2DXeUlLOPI1jyil1dah AVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fIkAHXyzJmFGlOZGYdhcWZUseZFDq65k/ZHlKT5XGjg=; b=pg0iCTntg9TSXT2QLH3GetQssY8V03EcK9dYzPif/k+4OFc6m5bkTRlN5sOnKdcJAP Q5lQZ0Zi4HkxpMZnXqygpf5bHxnaWBzI8RTDzMOZSd+Swkl8JN3uOw7jFZdLpMsi2OS0 l3TVlkS8GumluYe2oM9kYFH0GRycWGwpHrhIo6mr903+hdjJQyMmDQEvxvQDYi2wAeAR pVcZhXZISHtVcLa2KqcHjcNs7ucL0qzYEtbb/8tv9rcDppWYKExGOQ+DqyYVTPI6hAlb F1IWO3QOyW1t+TOEimOwPtKLwL0uJyXPu5p+Afk4tG2+REJoScGsAYFkUNkEednUZNmw AjkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSHJJGu7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s23si40171073pgq.516.2019.08.03.20.52.37; Sat, 03 Aug 2019 20:52:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSHJJGu7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbfHCPxu (ORCPT + 99 others); Sat, 3 Aug 2019 11:53:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:45906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbfHCPxt (ORCPT ); Sat, 3 Aug 2019 11:53:49 -0400 Received: from X250.getinternet.no (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B0C42085B; Sat, 3 Aug 2019 15:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564847628; bh=/Sz995kn2vhhOIU477qk6hrw4p98X9l1OrZDiibt7XU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LSHJJGu70TAXfJmFefWWrw0g4zM7f/OgvZzu+LanKMT685a0IqwtfeL4GeBoPcpQ9 TGJ5ZkXaE67LmgN7WIsBqG+BetrDYh0g91iaFSexahq5yMi1OW2jPRc8Ohhx6twoTB 5thGucacB/PRcaOUjpEucPUJt9Y/o9OJDF10Y0HI= Date: Sat, 3 Aug 2019 17:53:42 +0200 From: Shawn Guo To: Lukasz Majewski Cc: Fabio Estevam , Sascha Hauer , Stefan Agner , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: dts: vf610-bk4: Fix qspi node description Message-ID: <20190803155341.GT8870@X250.getinternet.no> References: <20190731141151.7196-1-lukma@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731141151.7196-1-lukma@denx.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 04:11:51PM +0200, Lukasz Majewski wrote: > Before this change the device tree description of qspi node for > second memory on BK4 board was wrong (applicable to old, removed > fsl-quadspi.c driver). > > As a result this memory was not recognized correctly when used > with the new spi-fsl-qspi.c driver. > > From the dt-bindings: > > "Required SPI slave node properties: > - reg: There are two buses (A and B) with two chip selects each. > This encodes to which bus and CS the flash is connected: > <0>: Bus A, CS 0 > <1>: Bus A, CS 1 > <2>: Bus B, CS 0 > <3>: Bus B, CS 1" > > According to above with new driver the second SPI-NOR memory shall > have reg=<2> as it is connected to Bus B, CS 0. > > Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device (vf610 based)") > Suggested-by: Fabio Estevam > Signed-off-by: Lukasz Majewski > Reviewed-by: Fabio Estevam Applied, thanks.