Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp1219651ybh; Sat, 3 Aug 2019 20:55:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkNoADj33/UTKVzUW383NUOB8r+nmj2AhE145JTVJhZNk4f95sdVTNWHUty30Bai2xhKPp X-Received: by 2002:a62:7990:: with SMTP id u138mr64460035pfc.191.1564890953597; Sat, 03 Aug 2019 20:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564890953; cv=none; d=google.com; s=arc-20160816; b=x6Y1q6Ch+0zRtuZHhss+Ri82J+rAg00ugTQTcYTbCmEcbdPcFn2xBhKiXfb4favtsm 0/UcP8l/ICtIBV8GLc76H2dRl9mqWtsqNa1rBsV87KNH0R9MoquEhA6FAT86lK8zSgv2 kPs+ToJz+/KmBHrt1N5Si4Xw3nB0IgeZW33dQ8n6MEAGjE1UhaWcBhTxGTUAOXWW1O2E AdLWdj8iIGbCER98awDTv1VLsZqz4Vsk0fbj5cKOemwSKXUryQGV6oTTCbvLzKdjgFbm 4dxPOTbuhOUb7+PbxV+btTP6fU5WxKR0+qsCTbC3YrgsziDHBgxihW2umXe7QHO5quQr FcAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=eyxZxTomFfPbWiAetqtPgtMLib3xCsrhPFW0Jq8wnRg=; b=iRA4b9sft1fqKT0SkzS39W1LhZNM20vEM1P5RhODRYOZHa/qSige2NID3EklWOIUQC kjKflZxFPDJ7xkOvqAXS4sl8JRSa3WVsnZ0zNN0wxMK8a6izzB8uKxDifBklOn2nTRsw aFbkdg2NWLTb4jHz0YKN/Ylz0c002fkvQLXSEKCJqhAKALmoZRP5ZDxeOrPvrPD1yU2V 4l/odEMBYoh5yH1RqmvOiC1vmX7nouAkK61In4Bx+GFqUOOY2js14l/SuyOU2SCAIqxe K984tqBtAiAcFHnCY6MZjtkkLOyPzbL6Dl8EXmIRvMrTaXGOIFHsaP9g30/LAXhqiVok TSUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si38612381pln.150.2019.08.03.20.55.38; Sat, 03 Aug 2019 20:55:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388659AbfHCQer (ORCPT + 99 others); Sat, 3 Aug 2019 12:34:47 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38783 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388570AbfHCQer (ORCPT ); Sat, 3 Aug 2019 12:34:47 -0400 Received: by mail-lf1-f65.google.com with SMTP id h28so55003042lfj.5 for ; Sat, 03 Aug 2019 09:34:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eyxZxTomFfPbWiAetqtPgtMLib3xCsrhPFW0Jq8wnRg=; b=ByGliOBNf2MJ9nGx9SrHlT9ciAT2kc8o52wCYqX4cALI7L4j0umm8/nBaHqAOTfZhg S3w3nC8P+nO4/5KRes5mBvLCWYU3XoYzBkb97/DOnY6mjr5Uykib4b1V86koWvZiVf1E MT90sxnNI96IMmUl0jZTEKbxVJZpjDMHzkPykUFUcyaP1IxxUeNUetuetmDROi53aXY9 FwUTo6ECvJ12oivAYi7xaMBPxej04hanqszuccMOUopfEDlDQq7UNaA9Mm/h6K1m7Oon aqtT0XX5YhJsPzV8USo53dp2885CHSZ+SztuBbiMGAc/c+wur7AG/8t/Rg/XLcQgDZ2i siag== X-Gm-Message-State: APjAAAVoHup+W24dFI0so+Cwub0JXzkpPBdEKLIDsMpPvwpq+sbAgowL 5/FCpmIiso1tua3ZXM0TT9SlieF4RVkLbPHJh8d4MHfU X-Received: by 2002:a19:ed07:: with SMTP id y7mr28943779lfy.56.1564850085457; Sat, 03 Aug 2019 09:34:45 -0700 (PDT) MIME-Version: 1.0 References: <20190723012303.2221-1-mcroce@redhat.com> In-Reply-To: <20190723012303.2221-1-mcroce@redhat.com> From: Matteo Croce Date: Sat, 3 Aug 2019 18:34:09 +0200 Message-ID: Subject: Re: [PATCH net-next] netfilter: conntrack: use shared sysctl constants To: netdev , netfilter-devel@vger.kernel.org Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , LKML , Andrew Morton , Tonghao Zhang , Kees Cook Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 3:23 AM Matteo Croce wrote: > > Use shared sysctl variables for zero and one constants, as in commit > eec4844fae7c ("proc/sysctl: add shared variables for range check") > > Fixes: 8f14c99c7eda ("netfilter: conntrack: limit sysctl setting for boolean options") > Signed-off-by: Matteo Croce > followup, can anyone review it? Thanks, -- Matteo Croce per aspera ad upstream