Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2205371ybh; Sun, 4 Aug 2019 20:16:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLKKL0f4s+zbEO1oSCw7vcO7Mfd9I/jE0ynaY8WVvdm8i7ZP48nXay6uhxqD+ABzSzKBej X-Received: by 2002:a63:fe52:: with SMTP id x18mr135176970pgj.344.1564975004035; Sun, 04 Aug 2019 20:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564975004; cv=none; d=google.com; s=arc-20160816; b=SE7ffDHm3L0jZr/+STFcFB5CWCz3C1MJQq/pCjrxnxDpYXAKxqRs7Q8259sq8qeexa A0N+TYK4bhj4gbtgNUlQPkOPzdM796Iu4IHJdT6RMaLVgyOTIOIBZozP7z9WHRa7OHgn Kcb+3tw3BM8C/PUdbg/UB2EKjLojZZyzNCuI/sZWvcoZgYcwxOfreJqGyo2hAsWbPSHw FGIFlDw+853SLq0XEdLzixWFDzqUO0ktq5CZXJStAQ/HinVFlnnJylshAMUxa9LTX6/9 BXjAcfmP/Uin9tWQXdyJndVYE60e/JlJLECRFpcAifcUfc11vS2fwm6MiEakVxbtSjU0 Sxjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=noXj2zv7z1wAM+pC/uKwav3YTTLDM3SRBogNdP8Bf/k=; b=OynpeQJRniTElIqRMqm6NNIpsES9XjGhGHToH5PIYSkcHY2ZdXv+2d/9FnRqLc5JMO ZuqvztiFZuEcEiJxKcX3zcxRUR/3ZTPoeDhi4Bywi6nkucsIHyr4OKl1I8WQnhac/KK3 JbI0CWgRtWZpxFihA8xiw7QocYPnoEVwy0+rrhAGd7zddZk7jHi38jWO2upjpoJDZ2PK zZ7CZVCiYMhWqsVcUu6tdjt+Dy5wf1hze6e1YCovJdEUPxhh7cSjpAsYQcMsBpLfklvY 6c5KgXt7jxXHO13kBQhsqsPAfnX7MzZ8a3WDgtkEng1PBzx4JZjR4dY2i9ALqsF3PmIO WCUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si42140396pgl.323.2019.08.04.20.16.28; Sun, 04 Aug 2019 20:16:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbfHEDOT (ORCPT + 99 others); Sun, 4 Aug 2019 23:14:19 -0400 Received: from inva021.nxp.com ([92.121.34.21]:53928 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbfHEDOS (ORCPT ); Sun, 4 Aug 2019 23:14:18 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 9BA032001B1; Mon, 5 Aug 2019 05:14:17 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 389702001C7; Mon, 5 Aug 2019 05:14:13 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 84111402DD; Mon, 5 Aug 2019 11:14:07 +0800 (SGT) From: Richard Zhu To: jassisinghbrar@gmail.com, o.rempel@pengutronix.de, daniel.baluta@nxp.com, aisheng.dong@nxp.com Cc: linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Richard Zhu Subject: [PATCH v5 2/4] mailbox: imx: Clear the right interrupts at shutdown Date: Mon, 5 Aug 2019 10:51:29 +0800 Message-Id: <1564973491-18286-3-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1564973491-18286-1-git-send-email-hongxing.zhu@nxp.com> References: <1564973491-18286-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure to only clear enabled interrupts keeping count of the connection type. Suggested-by: Oleksij Rempel Signed-off-by: Daniel Baluta Signed-off-by: Richard Zhu --- drivers/mailbox/imx-mailbox.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 1eeabc5..afe625e 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -219,8 +219,19 @@ static void imx_mu_shutdown(struct mbox_chan *chan) return; } - imx_mu_xcr_rmw(priv, 0, - IMX_MU_xCR_TIEn(cp->idx) | IMX_MU_xCR_RIEn(cp->idx)); + switch (cp->type) { + case IMX_MU_TYPE_TX: + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx)); + break; + case IMX_MU_TYPE_RX: + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_RIEn(cp->idx)); + break; + case IMX_MU_TYPE_RXDB: + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_GIEn(cp->idx)); + break; + default: + break; + } free_irq(priv->irq, chan); } -- 2.7.4