Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190805145736.2d39f95b@canb.auug.org.au>
In-Reply-To: <20190805145736.2d39f95b@canb.auug.org.au>
From:   Chuhong Yuan <hslester96@gmail.com>
Date:   Mon, 5 Aug 2019 13:37:27 +0800
Message-ID: <CANhBUQ2gBYtPhyfBizu1T6V+XCoyy-bKgkqiHKY2ZOHskg_s_Q@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the crypto tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 5, 2019 at 12:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
>   err = devm_hwrng_register(&pdev->dev, &np->hwrng);
>                              ^~~~
>                              cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
>   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
>

It is my typo, thanks for your fix!

Regards,
Chuhong

> I applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
>
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/char/hw_random/n2-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
>         np->hwrng.data_read = n2rng_data_read;
>         np->hwrng.priv = (unsigned long) np;
>
> -       err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> +       err = devm_hwrng_register(&op->dev, &np->hwrng);
>         if (err)
>                 goto out_hvapi_unregister;
>
> --
> 2.20.1
>
> --
> Cheers,
> Stephen Rothwell