Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        nd <nd@arm.com>, Liviu Dudau <Liviu.Dudau@arm.com>,
        Brian Starkey <Brian.Starkey@arm.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.1] drm/komeda: Add support for 'memory-region' DT node
 property
Thread-Topic: [PATCH v2.1] drm/komeda: Add support for 'memory-region' DT node
 property
Thread-Index: AQHVS3QM1TQJ/XVHokO2F4Ib3nbRwKbsVfKA
Date:   Mon, 5 Aug 2019 10:13:35 +0000
Message-ID: <20190805101329.GA26357@jamwan02-TSP300>
References: <20190802143951.4436-1-mihail.atanassov@arm.com>
 <20190805095408.21285-1-mihail.atanassov@arm.com>
In-Reply-To: <20190805095408.21285-1-mihail.atanassov@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 9c82a4e2-f401-4e16-c780-08d7198d9ac1
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4990;
X-MS-TrafficTypeDiagnostic: VE1PR08MB4990:|HE1PR0802MB2604:
X-Microsoft-Antispam-PRVS: <HE1PR0802MB260484EDD79A0248B9638034B3DA0@HE1PR0802MB2604.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:568;OLM:568;
x-forefront-prvs: 01208B1E18
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(376002)(396003)(136003)(366004)(346002)(199004)(189003)(76176011)(9686003)(6246003)(6436002)(6116002)(99286004)(58126008)(6512007)(86362001)(81166006)(81156014)(68736007)(53936002)(33656002)(25786009)(486006)(1076003)(6862004)(476003)(8676002)(229853002)(186003)(4326008)(5660300002)(66066001)(71200400001)(71190400001)(66946007)(8936002)(64756008)(66446008)(52116002)(305945005)(6486002)(7736002)(256004)(2906002)(316002)(66476007)(14454004)(55236004)(11346002)(6506007)(386003)(478600001)(26005)(6636002)(66556008)(446003)(54906003)(102836004)(33716001)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4990;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: kx2j+QcQI0+cAgUjxfN+EiB3pTJnDGIt3L+1gOmXIy6A4Gbh7s0C1TPSD7gCl48eUavDWjj4Cy3XEAUz0pjesBuTboCM3nBLliZb7lWurmCAua6Ycbe9RsPaFMpgot5WpKVeQt/c8FBrQULcM+lSBLUzuZxgjbMZgpIBqCEjfU4K6LRT8TsijOWbwEpKfHaMgXSNpRjbRGkPEsmaMxUMKwdLxkFhjWSlE2andBS2gX+bf09vOIio8V9TFLVMBIpqNUo03XmyekZZfAWWXZR1FWTi8hvh22GpdYuL7M0dEMajJdHrTPHaSrMWzrBbNQYGiYHd/6tivYiGHWvXpBtiZNJFQQ4yZTuNP3rSXa/Yty81Uw9Jcaz6plLkv19Kkd4RcWAS/DmtrKM9evFahk6v2y8UccFqgXyiiEzDjFohAtw=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6ADE09C3D72D084489D86BAC215FC774@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4990
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(376002)(136003)(396003)(346002)(2980300002)(199004)(189003)(126002)(4326008)(476003)(46406003)(63370400001)(356004)(50466002)(5660300002)(86362001)(11346002)(70206006)(446003)(63350400001)(33716001)(26826003)(14454004)(7736002)(305945005)(1076003)(70586007)(76130400001)(6506007)(102836004)(386003)(486006)(97756001)(6862004)(6246003)(47776003)(66066001)(6512007)(8676002)(81156014)(81166006)(316002)(23726003)(336012)(99286004)(6116002)(3846002)(33656002)(8746002)(58126008)(36906005)(76176011)(54906003)(9686003)(26005)(478600001)(8936002)(229853002)(6486002)(186003)(6636002)(2906002)(22756006)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2604;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 573274d8-6632-4bea-3df2-08d7198d9373
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:HE1PR0802MB2604;
NoDisclaimer: True
X-Forefront-PRVS: 01208B1E18
X-Microsoft-Antispam-Message-Info: TQ4ZG498Q0ZzrJvtIj50YnIMeAulqaFLjBTI4yPwi//HGNSZ7ChMPNCKbIx9oSnNuFW7RbySIa7r7UNP0z1nSRJFb6k8XTUzYwosIjyBwAPv5A+JaeRGwOuUt/BQoc7mHZoYIoREp1vH/PSOzByL6g9HCxQqTj5s+kG4jmAjJiXJOUScn6OFmdMCS0MpilKOExzLmtuAb4SwHLpxGNMyOEj0pERCY4M9MVccgY7nT0FANqWlyxIQHgt34jReJDW5gE555to2LUFUXCkiBFzqfyGgwA4r0goniG5pyoOP6lE4FB78xXFeB9VKPq1zgXqCqQ2w8o68Zu4k9ycrQzxm3PpnUXAvUTvRdRi1+LZz/Rc57HxbGQQsV7czEzJw7W+zPwObJbHMLOhvJ36BgCMQzK1+JrlR7LuebjueBl7D5Uo=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2019 10:13:47.2907
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c82a4e2-f401-4e16-c780-08d7198d9ac1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2604
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 05, 2019 at 05:56:25PM +0800, Mihail Atanassov wrote:
> The 'memory-region' property of the komeda display driver DT binding
> allows the use of a 'reserved-memory' node for buffer allocations. Add
> the requisite of_reserved_mem_device_{init,release} calls to actually
> make use of the memory if present.
>=20
> Changes since v1:
>  - Move handling inside komeda_parse_dt
>=20
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gp=
u/drm/arm/display/komeda/komeda_dev.c
> index 1ff7f4b2c620..0142ee991957 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -8,6 +8,7 @@
>  #include <linux/iommu.h>
>  #include <linux/of_device.h>
>  #include <linux/of_graph.h>
> +#include <linux/of_reserved_mem.h>
>  #include <linux/platform_device.h>
>  #include <linux/dma-mapping.h>
>  #ifdef CONFIG_DEBUG_FS
> @@ -146,6 +147,12 @@ static int komeda_parse_dt(struct device *dev, struc=
t komeda_dev *mdev)
>  		return mdev->irq;
>  	}
> =20
> +	/* Get the optional framebuffer memory resource */
> +	ret =3D of_reserved_mem_device_init(dev);
> +	if (ret && ret !=3D -ENODEV)
> +		return ret;
> +	ret =3D 0;
> +
>  	for_each_available_child_of_node(np, child) {
>  		if (of_node_cmp(child->name, "pipeline") =3D=3D 0) {
>  			ret =3D komeda_parse_pipe_dt(mdev, child);
> @@ -292,6 +299,8 @@ void komeda_dev_destroy(struct komeda_dev *mdev)
> =20
>  	mdev->n_pipelines =3D 0;
> =20
> +	of_reserved_mem_device_release(dev);
> +
>  	if (funcs && funcs->cleanup)
>  		funcs->cleanup(mdev);
> =20
> --=20
> 2.22.0


Thank you.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>