Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2640615ybh; Mon, 5 Aug 2019 04:26:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLSAimVqBqslhNfop1XEKu4/JZaYD/VvG6Glg90uuQ6yhmplJDjOr4xBjHRMTs/D7MWaZ3 X-Received: by 2002:a63:e148:: with SMTP id h8mr24967000pgk.275.1565004379239; Mon, 05 Aug 2019 04:26:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565004379; cv=none; d=google.com; s=arc-20160816; b=VF4WXoWeAYtRDRQGn2Nm7kPZI11mxk7rICnpkr1StAJi4B+D14XXoFWGAdre1SqmFr mpwPxtTq5IyQLgXEktnbfHgu11wSXUFCeCvJgIPai8toJiV9zo7IG9tLSwwRvIqteaK8 q2onF78fbKRVktWcLKSRkri3npAxUcf5sejwJbDfO780ba+P2unoy32d3llnzUk/vLqf DH1oTMZDTMPoAfl2Jw+cOOg/kX8bYX45YoYvZT9Dh7aalctG+OymvO+Nyxgc/KYQbxX0 Si87/GBQ6MCSkT8ebD8Aav7ZIU27yFsklyGsIMlp30RugvHTzRAMrgAIy5CoXs9DTY26 KDlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=yO3IjPZhy8xeOjJxJvmE3Qd/RCJXikfSTjciEqZALp8=; b=GJYqESgx+VJOAaO8wmgPwAGeOWyy6/MPkDiih3tZb3ivmb+him2VNxRXAPceipOPIp laRb26pOCMit3E9mn50IX+3Ctquw2l1M3NK+FkiJ+GS+08ZGdUOwmFcPqvEDUVs0Vd1O kqvWYsCjMB74ZXdCiVejSng3GRI0sm6i3Npyz/2YW8gjB2st0y0J8TsH7ArRgVqe443U jhdHV35NsU871M4GWS4lGUfhgI/cL6wKep6aifQf0M02hZO6ziv4zcHjvpktE1/vMHDm f6FC7ICOGI35Zrg+4y4/sVG5suF8s7qqR4ahumP6gURdz72KPzfOlO9K1cvsEH2NfBFz Xjwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GN0V1l+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z190si10747203pgb.182.2019.08.05.04.26.03; Mon, 05 Aug 2019 04:26:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GN0V1l+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728532AbfHELZJ (ORCPT + 99 others); Mon, 5 Aug 2019 07:25:09 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:39384 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728508AbfHELZI (ORCPT ); Mon, 5 Aug 2019 07:25:08 -0400 Received: by mail-lf1-f68.google.com with SMTP id x3so3870156lfn.6 for ; Mon, 05 Aug 2019 04:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yO3IjPZhy8xeOjJxJvmE3Qd/RCJXikfSTjciEqZALp8=; b=GN0V1l+pQRKCt/P/RNcyC2+LzMJgDuUTfzEUQVDrQmJ2M6dpVTmViAi1QTrEk3mr5L Xq5JLeExSgxEnBFOaILHFsGjaJA5Sl0kDMQUVaAp8FHNaKHZlFZR4J4vsvyoRTdi4bEG lEzOAZEfdY0deoaC9NssyhYYEItwLH51Tx5ytfpoflrR9pMGdbtYQ2HAnVm8HyLSKgsB HWK2ItHaTFTSxHz5Apphozd2xbrOt7P0q2wFLUW543d603nYCMPl77AesvHz0w8Yheiz r7kyAqVrkZSuYGuEKvtkJ+OFhfjOQ8d/HTCsOdHlN5sUhkzZn40l/8/nm6k3kLv5FXzD MWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yO3IjPZhy8xeOjJxJvmE3Qd/RCJXikfSTjciEqZALp8=; b=KAmLNxVjejnAfA4uPaOt3GCRnnAbDKO+kUOO9rt88nIR3MYoB4MoZTsdysj3MLD+Ko 9CbQM5hbWsZt59/lLmPnx+LxSzMev5fVvEnr6UwHkhe6g1u66t7xNbV0y5weEfOeP5EQ Qm+u82huBDHTJnPz3UUc4b3I3g5W809Q2kRuhpOTuN8bGgzFj5189YRcXCi7kB0+BE95 kQr57hoSs4eeQ2RzHhhgrHpOHinRmB4rbmG25wHs4hLwn0utnq84U/fPUx85cbsusjyJ 6IZqrb+F23PNaF+HlfAFJbXLoyOjxB97j9pyRYegysMM9KGKQK5Sd35L8fxPiwmhNnD0 jbMQ== X-Gm-Message-State: APjAAAXUxAzvc3Mv8L2eiP8dDaq6f9fdBtlcqE8rhveYf5apKPNg30qX pXuQrurterpt9eQYFGvoBC1lYyrbhf93mOLkR0Tig3hM X-Received: by 2002:a19:ed11:: with SMTP id y17mr2033424lfy.141.1565004306873; Mon, 05 Aug 2019 04:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20190730181557.90391-1-swboyd@chromium.org> <20190730181557.90391-34-swboyd@chromium.org> In-Reply-To: <20190730181557.90391-34-swboyd@chromium.org> From: Linus Walleij Date: Mon, 5 Aug 2019 13:24:55 +0200 Message-ID: Subject: Re: [PATCH v6 33/57] pinctrl: Remove dev_err() usage after platform_get_irq() To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. (...) > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd Patch applied to the pinctrl tree! Nice work. Yours, Linus Walleij