Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2641883ybh; Mon, 5 Aug 2019 04:27:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqfKf9t3ceCwoJCp5ggRhvB4UmGPzbbqixefMA0navuIq56fcnhFb7HGGJE5quESjL/yIE X-Received: by 2002:a17:90a:9bca:: with SMTP id b10mr17544422pjw.90.1565004459900; Mon, 05 Aug 2019 04:27:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565004459; cv=none; d=google.com; s=arc-20160816; b=BCExFoPXMeQdJ5+y8VRUL2ufZE/3NWamkiq8lJKMyoFuzaQVqDq0aLRcws+cmeV0hH 9j5s7y5KNxZhyc1GYqJGcIpuT/VV/uN9c9sULdYRIIFZqaDPy7C3Q597j6wbaBmb/CFE 1veaTWi1TseKDHTdgxEP4VwwRmLSPkprG2AGGmNCU3tTtdFBqEd4s8olzi6vpTGeTzMN VUY+5m3B383urUiHIoyyZSSrBv2KNdrWbW9d1xnnK0y5wVbzNt4t/EDJNDTCME8V5AXg HBeRwhRLzW4mUYeTFeoZoa3/r10R0W6TLiLBEGGoBa1xWUE1n0Ef03NtcizvRs1Pnv0R oC4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=jIRa3TvqiJWaXbGz1Sxgf45N57AQXqRegz7cACuc68A=; b=TMbVhH5yjt5lvPwBgjcbbfc8yoOE03R81U27ySXtR8D4wggELzw1Roi2YRBApq4JN1 1uFkdn3qugKqr/E7nIk98jVZm2cverHz3u6wqJKkUhrCFzDnO4DAF9LDTf5oIJ1M2Ua4 usD5M3tKRMWZEOJ3peQWaPyJU4yWVw9o/BiEq1Febt79nCMu2ku/w2Lbhv14xzHSyTMB /QjqDCvxNlb+0fEUwvX9hnEr3KdiP0kz7K6G0/0o0k5QSvnzD7asVNqcKAUQXNlyGEGZ 57YGVXB4oe8ukSs0XVkByjap2Hi65Br38SSo3HHLKEcJtxRwHSPA7E1d6rUvuNPLlqMu YLgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qIT1QTF1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7si35460895pgi.127.2019.08.05.04.27.23; Mon, 05 Aug 2019 04:27:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qIT1QTF1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbfHEL0k (ORCPT + 99 others); Mon, 5 Aug 2019 07:26:40 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37958 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbfHEL0j (ORCPT ); Mon, 5 Aug 2019 07:26:39 -0400 Received: by mail-lj1-f193.google.com with SMTP id r9so78983641ljg.5 for ; Mon, 05 Aug 2019 04:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jIRa3TvqiJWaXbGz1Sxgf45N57AQXqRegz7cACuc68A=; b=qIT1QTF1w0efi6+3yipuwFrYZL30qqHrYgmctXv8UnneOjx2GgF+0JZtmxWgB1Mg8/ v+7dHYiNP7xfVA03cjMy3k9BEgBXLsYVymjoWiHzr3/5VNRBifxMEd4ZWVsXOKaAmTrB CcSQROuJEp6EE32Z1GgjQVsmuRDRbtCDceXuYg38GWcy27+AnKpv+kH4QLXoTIvYUobH dGpTPrusQ7v5U3BtBFHERMkYU90cXbkQJxsIMDQup9UDjnWGH5+uV4f6ygLlQHWhCnGm rMuIko9zudS/9WkGNeZXicg8j4Tw5FD2bvF67egZMkd3SiZN3d2Veb/HAxmtWny9+eXo O75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jIRa3TvqiJWaXbGz1Sxgf45N57AQXqRegz7cACuc68A=; b=qDVq3nlx/8OZAxLPb5cWcvUXSo/NJwob8p/AIejmCqyxTgw9RhAVHtXHjWloS2vJ8X WbB2DTcR131kZf3M2bkHv8pZkTPKeyTqzRrCkt+yXXIK2NlGxPXVWkI9iMgRMiYlZNXZ cSMSpOnyIqCqacMcdI/OJsTqHSu3alVJxboj8ggwf4yHxLFekn/oSK0LUUibug1EbTBQ x5pfYO30IT337hjqmUNcn9tmW4iHSNMUNMHVzyXykHyGugpu8XkHq8XyPMgL6CE8mRkY iAtamYPXdMs163Ji/2IWldYBS/wbdJGBt3I8WcreBMC2j2XqatewQCQRB9imyiUKe6yk 9hSw== X-Gm-Message-State: APjAAAXgNJBKk3wCmvBqeRHHbYtibfdtjDhV3vEsfqEhSwUKnvlEWnZ5 D+PNfUqnLBwVaRr1kIk2Cazzjkd9hGS7RozRWzdgpw== X-Received: by 2002:a2e:9048:: with SMTP id n8mr62373ljg.37.1565004397519; Mon, 05 Aug 2019 04:26:37 -0700 (PDT) MIME-Version: 1.0 References: <20190730181557.90391-1-swboyd@chromium.org> <20190730181557.90391-16-swboyd@chromium.org> In-Reply-To: <20190730181557.90391-16-swboyd@chromium.org> From: Linus Walleij Date: Mon, 5 Aug 2019 13:26:25 +0200 Message-ID: Subject: Re: [PATCH v6 15/57] gpio: Remove dev_err() usage after platform_get_irq() To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. (...) > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-gpio@vger.kernel.org > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd Patch applied! Yours, Linus Walleij