Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2679545ybh; Mon, 5 Aug 2019 05:07:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/Rwwp7qzPwLRqTZMrXPNTLrUzn0kti4PTYT6it9MO9n0HwaIvHkKBs7udz7WCBknGfV3i X-Received: by 2002:a17:90a:2244:: with SMTP id c62mr18310485pje.29.1565006854590; Mon, 05 Aug 2019 05:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565006854; cv=none; d=google.com; s=arc-20160816; b=p7Xvb/fTQyQuKHziMRcJBZPERTC+PBFDF2SO6NWfDjUUbt1gxEYyjhJPq38A/vL2XA zTSMSwpVoiZb4Bi95qDT7QGNKGxWtNIja+XdWtl5altGgxFTmbA+Ia7lwoiJoXYN3K6o obulpLgM5SZ3RHNa7BjpY4iOc12rl33PZU/Kq7ws4kWHhp5bM5U3fK+ORXJvASV1HIXo baPo0hBUqH5UVk6J2j+LoOd62VAHgKSszhcgZjTDRyTzMqgxnG0K+e3ChRC8i5YQiCBN bxqKCnn6FINVjX3UodJwMGvsRUNWgJCrAwINcXVMaFXkJvQk+YtRsl1b+u23C1b1x7R3 4k3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=axBd5F0QqLbqdPaB0feVUrYug0KwboaKqINhbHlJXv0=; b=DdysjnXEIsQbceEoPYVpszb+WBimHm6rCi9h5zO8FfyUBv6hVBKZae+ZK03+qcMMus tgu+sS19ihGuEymdtKxbi9r4wYDOEs9GxrwtnP3z/N9pAlu8mQHChTEGMESO1+pXSzy/ 6ysdzIfDI/jmgQEppn47KCCL7eNgiZsj7t87npXKkM7zjSWnYcaBSvnULuT6+HiT/6KG FJZkXCnc0wvNo97/IrhegLxxUSTGJ4C+9xNZF/4UigqYy+MJEDJ0H1ORAhQ3Un/UVhUg jq3MD/Q54qKlCquhIL2XGtnfmbM06yDIbY536IcYKmtAyGynW2oLGLg+7X4Pgtrha5r+ p5pQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h33si3713009pje.95.2019.08.05.05.07.18; Mon, 05 Aug 2019 05:07:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbfHEMGl (ORCPT + 99 others); Mon, 5 Aug 2019 08:06:41 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49745 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfHEMGl (ORCPT ); Mon, 5 Aug 2019 08:06:41 -0400 Received: from [192.168.1.110] ([77.7.70.5]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N0G5n-1iIikw2Pxv-00xL1r; Mon, 05 Aug 2019 14:06:33 +0200 Subject: Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button To: Andy Shevchenko , "Enrico Weigelt, metux IT consult" Cc: Linux Kernel Mailing List , Darren Hart , Andy Shevchenko , Platform Driver References: <1564081563-28322-1-git-send-email-info@metux.net> From: "Enrico Weigelt, metux IT consult" Organization: metux IT consult Message-ID: <0b2802f8-5732-52e9-0a95-b28d23239ecd@metux.net> Date: Mon, 5 Aug 2019 14:06:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:zILWaArSokcPaTMpjpK3s3auy6+xy9QkB0Sqa2fjj1HM1dZqmuv Ix+8GcRmNF/cR+R/tnxMEOWSW35LhjP0MIHQxt3iIncqiO/ZCntlzayFcV6n++CK9mD3MMM OmmW4PmGr2SDGSdUUxfMHtJ6pzX/GJ9Y5Lpjab/+E5CAS3/qFpG0BcfM6U8ikkoQh4XXlXv wHGzMMTVRrdHSvVsnM/RA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7g3//ffHaGE=:oheL3/eOGxapi9Z74+a1jf Ci8EQp5GHXvBIInQ30to+5OqO7cScSglZu4fjaQHal2dI9/1vXTSzOLSvZaVnnqgbnEujFuQj djcvLNXN/ndJ1eskLjO29pphZBryHQ9q5nkUygnJViNufpLCrGEyIpZ1U5m29MVgY9nhQUNGV OA72esDWVkmKC/Ny6DtZxrgs9YIG+BEia6EIlTLN+wsVQic3OWleRWYANEBXBBzwbx64UoYCh vbtjQyswTGdxeyEdjc45LpSMan8Dw82I0Jas5Sga5aCtHfUpe2OJ4Od+Fmd82BsdQIgikU3CR timBRvHZJSLfjo7GU2RApQqHg1kDmKbIq42Virdfz4oivJ1CRRihmso4Xk5sccZPpx5dKvyUb wq5Fgvy0R2k0KDIzkZcD+yR9ZzpwpHXkdZoJfgZwlzSBaSR+9Yqo5wp61FKwKoMrA5pjNW1Nj 9/OngJ0IBcbyn3tWt0V2/PTmUnptge+Z2mqnGcOZ87cTZepM3lJmUkz9wQ/DQBKvEU2t7xYFL jCZiXoKsZpLiFGDJzyzEWDcnb9P3obU35eiADOXe0a7kHYQupC7GpCzEQ3zl5rD2VMhu7wVFT fM18Fy6XaK8Jr0UA3BXAs0TVXxZQMCf1hIF2KlMtb3jUPYGRlTu0eJoq8/evHFxbgWfSpp+j+ lBiMUZsSve2TGsKVi6DJBDFWkol/BEV2ClOlxhUGYSd73/7GQ9BOrZDTo9mSxQdjMW7pHyfhI bpa4ragtRgnueIkpajFtKHccKyDNjmw1Rp7RayIf28A/svQNQgX6VjD+QWU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.08.19 17:00, Andy Shevchenko wrote: Hi, > On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult > wrote: >> >> From: Enrico Weigelt >> >> The keycode KEY_RESTART is more appropriate for the front button, >> as most people use it for things like restart or factory reset. >> > > Applied, thanks! thx. > >> Signed-off-by: Enrico Weigelt >> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver") > > Please, use allowed minimum (12 nowadays) characters of hash. hmm, do you happen to know how to configure tig to show the short hash ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287