Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2795104ybh; Mon, 5 Aug 2019 07:00:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqx78r1rqjwdEbLrASX9h5hc7+WXEvrODE7y6v8Rm+yLywIsb+0yjObWXqmOpZE1+cIkAzYB X-Received: by 2002:a17:902:e613:: with SMTP id cm19mr135095432plb.299.1565013609391; Mon, 05 Aug 2019 07:00:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565013609; cv=none; d=google.com; s=arc-20160816; b=AHceeCSjGF+YzwD/jbxY9s/h/LHFQKXrM5vG/C1h5RDudoHdlGCCRXE7E7/n3f7Ww1 TVTGyY70cL2Jv+1s+XCMq4+0fTPi1MoNB+di1YLWCR9oaR5nA/RJ5F/aZBXATn43NIaV vhMip+bWNwowsJHVQdaD9loTuhvJWN2wllPkuZfNOSPvFq4HMwsSfqWD7hGbpRxBkNrI TPjQafaGmscGGgOOufc6X1PTLJE3rO9wMUdnT028aK+MImyGFyqMBHYAS1kl2JAMkMod RlueOx5wbaCA7U2OPz3+WTIgDMCk7N5XA5286VBoSL/bX4LRRmYjI0uF6HpDbhpy281J JH5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=WrR/fw0Sk+FDW+ododtWLM4aDpd0XJ6l+M75JpKq258=; b=a7Hxtg40/zif/0sS9Jblx20fgmFq8hkps6MIRdOOSUi61II0LglDRFv+s8H0cDIJUy vX4lLP/6hoN7v1hTEyDsKQTwMBfp2cIRSYrEBBQIL9qMB2FtrXDeu/OdnIU7FeQ8YBL5 Ij6nSqeCixP+a2z5vbObufHboZxoijj/wOBqM96RqKdJ652rqM4nDX50Bf3cOSUFqDZE nKWLp20/XPlqOsnrBUSpGhgAaUXktvOztOoRy6Cg08lIoOW1dknRMrD4N5qJI0vRwqIL mxUDsI8lxKQd90Jdcd+HzkFyWEAGLoXyT+vFiQ6aEzP84GVHA0J/jTTDm5cAZTnQQpfs FoHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gb4si42079098plb.429.2019.08.05.06.59.53; Mon, 05 Aug 2019 07:00:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbfHEN7V (ORCPT + 99 others); Mon, 5 Aug 2019 09:59:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:46312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728760AbfHEN7V (ORCPT ); Mon, 5 Aug 2019 09:59:21 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E502120B1F; Mon, 5 Aug 2019 13:59:19 +0000 (UTC) Date: Mon, 5 Aug 2019 09:59:18 -0400 From: Steven Rostedt To: Will Deacon Cc: Joel Fernandes , Jiping Ma , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, mingo@redhat.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, takahiro.akashi@linaro.org Subject: Re: [PATCH v3] tracing: Function stack size and its name mismatch in arm64 Message-ID: <20190805095918.3942c45b@gandalf.local.home> In-Reply-To: <20190805112524.ajlmouutqckwpqyd@willie-the-truck> References: <20190802094103.163576-1-jiping.ma2@windriver.com> <20190802112259.0530a648@gandalf.local.home> <20190803082642.GA224541@google.com> <20190805112524.ajlmouutqckwpqyd@willie-the-truck> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Aug 2019 12:25:25 +0100 Will Deacon wrote: > So, I completely agree with Steve that we shouldn't be littering the core code > with #ifdef CONFIG_ARM64, but we probably do need something in the arch backend > if we're going to do this properly, and that in turn is likely to need a very > different algorithm from the one currently in use. And I'm perfectly fine if someone wants to tear up the current implementation, and make one that has callbacks to arch code (with defaults for those that don't need it). But it has to be clean. We worked hard to get rid of most "#ifdef" being scattered in the kernel, and I'm not bringing it back in my code. -- Steve