Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2927120ybh; Mon, 5 Aug 2019 09:05:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxHmMYXYoMRHR6xxc5iIWQiFYOfNJ1bd4x9BAOPmblVT3yqdMLLfNM+ZsR9CKi8f9IW9I+l X-Received: by 2002:a62:1652:: with SMTP id 79mr73858499pfw.20.1565021140580; Mon, 05 Aug 2019 09:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565021140; cv=none; d=google.com; s=arc-20160816; b=bQifLqzndFOZz91d3jxXIYWawDsm+nnZ88UQ56YADO1hMKJN7ahx/R9Jg3g+MPIn8S j4B37YGtWunaEBWd1dQWn8POOC0wQ+BeH4gBmNsZZ6h0op9y8ziknDhg2nESXaxOD7Y8 21lQt+wzghDNv6i4X1f88zhfe5M5Fj5pP65IzpFoBgakNWzEvYKfqTML5IVObyQLRmpP e7JZUcJANPKagDqWqWbdSs4mhGDc8mZvtDwIJS7yp7Ics1sNIabjG4/VkKwE4ljmeMPP awdqsuPmpqwvWUY+Dh3ATzMrOfzFFOdIyCDxzH0fZO8A4FQFtGjNhtCypcJGv+2wMMBC PP3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=daWYzaZWj62qtb5b9NApCaIh5kuULM99a9Dv8I6DZaw=; b=oEiLsdBv2b/7blDitJvR9l949Miqz/PajXDFarGLKtSo2dzAdIA4CQrVvDKjmoM7aO 8J5ksJPYw+rHQJMuLqE75kuOyEjQZeB8tuy4ni3z3YmZrGN+WhiC1UdwOLTj9TnTpCHU 9qCw00I1ubrCaIwE+Ht6addEU0Ln/0VF+iwXG2LTjA6yn6SPa4Mb2oudvQ2/7xe9hUaI tWU7ZxODrjjMh7e5VRDuRrhMN+KWDD40TaZ1HoNYCvizftoXC8pST6gGYKy6ICQZU4NI 4tM+zjSV945wQs/PAEXLiLnTjDAAui9XrshoVtbKQbKcCnfQvYSWThs2vLZyI7hmMefX 46lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x185si47126063pfx.243.2019.08.05.09.05.24; Mon, 05 Aug 2019 09:05:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729704AbfHEQEJ (ORCPT + 99 others); Mon, 5 Aug 2019 12:04:09 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:33115 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726847AbfHEQEJ (ORCPT ); Mon, 5 Aug 2019 12:04:09 -0400 Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id A3D53898A8990C361E84; Mon, 5 Aug 2019 17:04:06 +0100 (IST) Received: from [10.210.168.118] (10.210.168.118) by smtpsuk.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 5 Aug 2019 17:04:00 +0100 Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated To: Mimi Zohar , Tyler Hicks , Jarkko Sakkinen CC: , , , , , , , , References: <20190705163735.11539-1-roberto.sassu@huawei.com> <20190711194811.rfsohbfc3a7carpa@linux.intel.com> <20190801163215.mfkagoafkxscesne@linux.intel.com> <20190802142721.GA26616@elm> <20190802194226.oiztvme5klkmw6fh@linux.intel.com> <20190802202343.GE26616@elm> <1565020459.11223.179.camel@linux.ibm.com> From: Roberto Sassu Message-ID: <02f749ef-2438-a99b-c5b3-22bc97cc6b7a@huawei.com> Date: Mon, 5 Aug 2019 18:04:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <1565020459.11223.179.camel@linux.ibm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.210.168.118] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/2019 5:54 PM, Mimi Zohar wrote: > On Mon, 2019-08-05 at 16:50 +0200, Roberto Sassu wrote: >> Regarding Mimi's proposal to avoid the issue by extending the PCR with >> zeros, I think it also achieve the goal. > > Roberto, removing the following code from init_digests() would be the > equivalent to the prior code, without needing to make any other > changes.  Let's keep it simple.  Do you want to post the patch with > the change, or should I? I will send the new patch. Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli