Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp3044279ybh;
        Mon, 5 Aug 2019 11:00:20 -0700 (PDT)
X-Google-Smtp-Source: APXvYqy/IHV3K85wx9ZYdPwgDxpFXq+dCQd4hdLQn7NtmG3SX+e/qYEC6dVs7pMF/5VzmPnKmTpx
X-Received: by 2002:a62:cdc3:: with SMTP id o186mr74942382pfg.168.1565028020659;
        Mon, 05 Aug 2019 11:00:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1565028020; cv=none;
        d=google.com; s=arc-20160816;
        b=ssRdBlVc1a1644MZ1em8Q3nmp8Cj1cOtRDyq5fmffXP0bFZI4Jekf/8rmAc5Jmqrzj
         1NkD0WG5OtSDmmg/1xYyyK/jBMH4UjHQ+DIubDB/Hr4maYRUbCDItGqZhVmK2zYr8Gfj
         hp7B9VsvsvjP9/CO3tqWNkKALumX1MAOF7nB9dKV9eDD2eJ5vhLVjKbFXKtSJHmpYcMF
         mzq7pe1TwY3PWyz0TGXZ0PVh5/8g/iq8aY/V5VX5q4pGZMm/7IsvMnhMihamYp5LUN+j
         PPjYOzYrYH0nD1xRbY71ZYhkLBFMbYPC1X5lnaRgYZIcJgsKrG9xeQCyxrDAhruLG3uo
         PtKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=VJgJ8MLFEYNzgS0i7MGVBFo8ocNG0KhAx9MUNswhkC4=;
        b=PrCVE1wavSKciJCdbmjkQ+sX5F5J7sN6ad36iVMEIIljFT95Zhd3chQo3TzKEkB1Bm
         0cmGaE99Cr7MP7oQxuVVHqZmhdWxcLKRVPUMn9uVn7OcX02m0rSc+SSu8eE6evDgeBG1
         F5vL5pSnpxjBv8XiyrH3oFeRosPSZ1NO4N7JvviqCUt5UpUDna6VA0z49EiBxHlR1F5V
         5+MWi5RPbjHGkTlLv2qyqznZdhF1WlTM2tf9Wh4TwgvVmp0BLQkGbjiL3+f13HrUVJ3P
         spRJ9wZcO/aoclCJd6GTQRgpHQeHELZltf4VItjRzzu/IMN6tdKO64ULDw2CZ6FWTGxF
         8kLw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id l1si44282019pff.178.2019.08.05.11.00.05;
        Mon, 05 Aug 2019 11:00:20 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730044AbfHER6C (ORCPT <rfc822;radocaj.bane@gmail.com>
        + 99 others); Mon, 5 Aug 2019 13:58:02 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:59952 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726779AbfHER6B (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Aug 2019 13:58:01 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D8D7154086FA;
        Mon,  5 Aug 2019 10:58:01 -0700 (PDT)
Date:   Mon, 05 Aug 2019 10:58:00 -0700 (PDT)
Message-Id: <20190805.105800.1380680189003158228.davem@davemloft.net>
To:     mcroce@redhat.com
Cc:     netdev@vger.kernel.org, miquel.raynal@free-electrons.com,
        linux-kernel@vger.kernel.org, lorenzo@kernel.org,
        antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com
Subject: Re: [PATCH net] mvpp2: fix panic on module removal
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190731183116.4791-1-mcroce@redhat.com>
References: <20190731183116.4791-1-mcroce@redhat.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 10:58:01 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Matteo Croce <mcroce@redhat.com>
Date: Wed, 31 Jul 2019 20:31:16 +0200

> mvpp2 uses a delayed workqueue to gather traffic statistics.
> On module removal the workqueue can be destroyed before calling
> cancel_delayed_work_sync() on its works.
> Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().

Please post a new version with the flush_workqueue() removed.