Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190802195017.27845-1-ricardo6142@gmail.com> <20190802145448.0bcd5374@hermes.lan>
In-Reply-To: <20190802145448.0bcd5374@hermes.lan>
From:   Helen Koike <helen@koikeco.de>
Date:   Mon, 5 Aug 2019 15:52:42 -0300
Message-ID: <CAPW4XYYUQGungxgvDq5G7zhT3M+N75WrR1HoOFesMtU2hYK2dA@mail.gmail.com>
Subject: Re: [Lkcamp] [PATCH] isdn: hysdn: fix code style error from checkpatch
To:     Stephen Hemminger <stephen@networkplumber.org>
Cc:     Ricardo Bruno Lopes da Silva <ricardo6142@gmail.com>,
        devel@driverdev.osuosl.org, Karsten Keil <isdn@linux-pingi.de>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org,
        netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Fri, Aug 2, 2019 at 6:55 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri,  2 Aug 2019 19:50:17 +0000
> Ricardo Bruno Lopes da Silva <ricardo6142@gmail.com> wrote:
>
> > Fix error bellow from checkpatch.
> >
> > WARNING: Block comments use * on subsequent lines
> > +/***********************************************************
> > +
> >
> > Signed-off-by: Ricardo Bruno Lopes da Silva <ricardo6142@gmail.com>
>
> Read the TODO, these drivers are scheduled for removal, so changes
> are not helpful at this time.

I'm sorry, it was me who suggested Ricardo to make this change
as his first contribution, I didn't see the TODO file.

Ricardo, it would be great if you could send a patch to another staging driver
to get starting and to learn how the kernel development cycle works.
Feel free to ping me or the lkcamp group if you want some pointers/guidance.

Thanks both for your contribution.
Helen

>
> _______________________________________________
> Lkcamp mailing list
> Lkcamp@lists.libreplanetbr.org
> https://lists.libreplanetbr.org/mailman/listinfo/lkcamp