Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp3157033ybh; Mon, 5 Aug 2019 13:08:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwInE6LNBYQlUdP3fRMU0jVLRZqib9M4xTURmLzCp673IaqCHP2SZUZhZzEwuBNYz9kEBwR X-Received: by 2002:a17:902:bd49:: with SMTP id b9mr51661708plx.343.1565035723787; Mon, 05 Aug 2019 13:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565035723; cv=none; d=google.com; s=arc-20160816; b=iHqfE5IKAsxwyb6CJ4pBr5PRiJYhkxiDFLISOBzWhnPzmY/CA9dA91BuIjUGnMABf4 lLQoj9O8wBfcPmx8qqLUhEp4S4WTzoykQGBaXxWMlCNMnnanfVm8gURLSSkrfT6X4J/9 bfUIOaFMddq99YEnFa4JrB/ZqzR7g6iDZSKCDz/Mi6ne05MpnQdmIBzjpDRSAP9GNNLs qPY2pxZikqLO4QZuh4/GzL9LS3D5HUd8MqZNNhG6gFPcPH3ju3at5ru+CtARfvSatLgq RwsJAWoSBRS2OfKitpTO/6FgQ+KlSHereLXdjdtCN3YCqK8CxUcr+Hh3kTSLeD9uMrgs CR2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=I+/FLS8eqxb1UNBY39cu1xBfCi8bcMalBd0zD3RfHPI=; b=YdCpptwlZ3Op8x9B5GqZLX3JdxXr03hmniXBxiF9NVY+FzvjLE6+ORRixale/CjKII i75t7yaI8CJRFJfE7AYJU9NhiI2TPcdLHgPqrIBy04Q18XvxHR9QH6EI7+TA4wX6malK SKl+1MqWPJVBbkqpXcYVhSu3h0A8+IAJSRR+DaORb2ko9mQGz7bXKYJaJsJip/epTSPi 2B5puwvg0fj8ePTPTYqaaqXVd5p1UDYMVa9mJklNepP1+947uVrvXV7YVfJCA8MtN5Ma twxY+ixV9GZsjUUC1yITVNDv6iLktVaL5X4i+x92Jf+a//kkKnnLbScrWO9JYMJz0wEE 9HRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i41si13301597pje.45.2019.08.05.13.08.28; Mon, 05 Aug 2019 13:08:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730574AbfHEUHX (ORCPT + 99 others); Mon, 5 Aug 2019 16:07:23 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39624 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727460AbfHEUHW (ORCPT ); Mon, 5 Aug 2019 16:07:22 -0400 Received: by mail-ot1-f65.google.com with SMTP id r21so80860704otq.6 for ; Mon, 05 Aug 2019 13:07:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I+/FLS8eqxb1UNBY39cu1xBfCi8bcMalBd0zD3RfHPI=; b=OeEwhYV7B4iMfndbdM82jbZ4p9BFqRGdqLc1IuvkOgXSvF9CzgFQ408HLex96+aO+Z J/aKOzwLjtgHfIapm3US7tnLRI/hXpnlaqwf57shrfDqV7LLlw4WvBU6LGWd5WsWjxMu Eucfljs8iWHey23T+BelqWllsf+F0uTFjQmz1RDQOMAXsv/yHdXhleJTyC9iqVem54vA mQ/laI/F/Li7naHPYhHrpmYCx4NoSFvPXrqWvACpTSGo646mREAc6ea89Y//H651+MB7 FjWhxj6fZHxVPijxuNx7TGKqiUrzit+Lm2EOQ8IxaGOItbXF9Nj+ez1KD/IGxLZpVM+l E9Jg== X-Gm-Message-State: APjAAAWHcJrsQu1Gl381cNDPUuAxsHM/JgzBECzrVV0pGyYInl/Mrpjw phtjIVbgnbt3JKzRiGmU37U= X-Received: by 2002:a9d:5a82:: with SMTP id w2mr110989797oth.240.1565035641798; Mon, 05 Aug 2019 13:07:21 -0700 (PDT) Received: from [192.168.1.114] (162-195-240-247.lightspeed.sntcca.sbcglobal.net. [162.195.240.247]) by smtp.gmail.com with ESMTPSA id k10sm28318977otn.58.2019.08.05.13.07.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Aug 2019 13:07:21 -0700 (PDT) Subject: Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers From: Sagi Grimberg To: Jens Axboe , Keith Busch , Benjamin Herrenschmidt Cc: Damien Le Moal , "linux-kernel@vger.kernel.org" , Paul Pawlowski , Minwoo Im , "linux-nvme@lists.infradead.org" , Keith Busch , Christoph Hellwig References: <20190730153044.GA13948@localhost.localdomain> <2030a028664a9af9e96fffca3ab352faf1f739e5.camel@kernel.crashing.org> <6290507e1b2830b1729fc858cd5c20b85d092728.camel@kernel.crashing.org> <20190805134907.GC18647@localhost.localdomain> <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me> Message-ID: Date: Mon, 5 Aug 2019 13:07:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> Ping ? I had another look today and I don't feel like mucking around >>>>> with all the AQ size logic, AEN magic tag etc... just for that sake of >>>>> that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem >>>>> to make much of a difference in practice anyway. >>>>> >>>>> But if you feel strongly about it, then I'll implement the "proper" >>>>> way >>>>> sometimes this week, adding a way to shrink the AQ down to something >>>>> like 3 (one admin request, one async event (AEN), and the empty slot) >>>>> by making a bunch of the constants involved variables instead. >>>> >>>> I don't feel too strongly about it. I think your patch is fine, so >>>> >>>> Acked-by: Keith Busch >>> >>> Should we pick this up for 5.3-rc? >> >> No, it's not a regression fix. Queue it up for 5.4 instead. > > OK, will queue it up for nvme-5.4 Doesn't apply.. Ben, can you please respin a patch that applies on nvme-5.4? http://git.infradead.org/nvme.git/shortlog/refs/heads/nvme-5.4