Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 0/1] x86/boot: save fields explicitly, zero out
 everything else
To:     "H . Peter Anvin" <hpa@zytor.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
References: <20190731054627.5627-1-jhubbard@nvidia.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <98d7c31b-c805-ce50-bd67-5bc448b524b3@nvidia.com>
Date:   Mon, 5 Aug 2019 13:28:06 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190731054627.5627-1-jhubbard@nvidia.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/30/19 10:46 PM, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
> 
> Hi,
> 
> This uses the "save each field explicitly" approach that we discussed
> during the first review [1]. As in [1], this is motivated by a desire
> to clear the compiler warnings when building with gcc 9.
> 
> This is difficult to properly test. I've done a basic boot test, but
> if there are actually errors in which items get zeroed or not, I don't
> have a good test to uncover that.


Also, if anyone has advice about any extra testing I could run on this,
please send it my way.

thanks,
-- 
John Hubbard
NVIDIA

> 
> [1] https://lore.kernel.org/r/alpine.DEB.2.21.1907260036500.1791@nanos.tec.linutronix.de
> 
> John Hubbard (1):
>   x86/boot: save fields explicitly, zero out everything else
> 
>  arch/x86/include/asm/bootparam_utils.h | 62 +++++++++++++++++++-------
>  1 file changed, 47 insertions(+), 15 deletions(-)
>