Message-ID: <439D3DB2.9010900@cosmosbay.com>
Date: Mon, 12 Dec 2005 10:06:58 +0100
From: Eric Dumazet <dada1@cosmosbay.com>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Nick Piggin <nickpiggin@yahoo.com.au>
CC: Paul Jackson <pj@sgi.com>, akpm@osdl.org, linux-kernel@vger.kernel.org,
       Simon Derr <Simon.Derr@bull.net>, Andi Kleen <ak@suse.de>,
       Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] Cpuset: rcu optimization of page alloc hook
References: <20051211233130.18000.2748.sendpatchset@jackhammer.engr.sgi.com> <439D39A8.1020806@cosmosbay.com> <439D3AD5.3080403@yahoo.com.au>
In-Reply-To: <439D3AD5.3080403@yahoo.com.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1108
Lines: 47

Nick Piggin a ?crit :
> Eric Dumazet wrote:
> 
>> Paul Jackson a ?crit :
>>
>>> +
>>> +static kmem_cache_t *cpuset_cache;
>>> +
>>
>>
>>
>> Hi Paul
>>
>> Please do use __read_mostly for new kmem_cache :
>>
>> static kmem_cache_t *cpuset_cache __read_mostly;
>>
>> If not, the pointer can sit in the midle of a highly modified cache 
>> line, and multiple CPUS will have memory cache misses to access the 
>> cpuset_cache, while slab code/data layout itself is very NUMA/SMP 
>> friendly.
>>
> 
> Is it a good idea for all kmem_cache_t? If so, can we move
> __read_mostly to the type definition?
> 
> 

Well this question was already asked.

You cannot move __read_mostly to the type itself as some kmem_cache_t are 
included in some data structures.

struct {
  ...
  kmem_cache_t *slab;
  ...
};

And in this case you cannot automatically add __read_mostly

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/