Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp3201448ybh; Mon, 5 Aug 2019 14:00:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqz65WvOpr4Pai0Pv1OIF+aGflUESTvwMw4z93AdwrUOJpFnqAqlRxhV4eIcfdrT33AlRvHV X-Received: by 2002:a17:902:7887:: with SMTP id q7mr28724100pll.129.1565038803845; Mon, 05 Aug 2019 14:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565038803; cv=none; d=google.com; s=arc-20160816; b=wvyn+9b9YeEcooqQTv3CGO36GngMpsH9SXz3eDBG6yIMvf+q1eqdz3Y/ieqDvB0Oee xuHsoVtSl3AzHCKngHzHnBEfCnPL087tldpHl72JU/x0MDdj3GczZKi7017e9g94siyP ZPYf3bndSwQMTwyvc07vUfNPvcBS1EuzZ3U3zEOPI8yN0IV0lBpCsvVNX8j8+iUb6OL3 BgWbod8rMNbUNfd3dTcrz2p6oHK95YxX8GbG5QXOTaCwnEnKgV3sW1+hQthmbwLZk8sK twwHyqH7EKg/l2UhtHqp3lX6zGdbkXCPPVKCJ9apPsRfyf/ALnj2w+9lw7Na0WyZ1ch3 ZHTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=9X2wQUGD6zLRbLMDjJdPs/T0gS5tBwgXYnxhEUgwlZs=; b=MEWDwoyWnTyJJgYt8txqfvnVK7TgxiMvt5+4v09rG2UTZW+KckyZ3njtN7Ye7MfJ4i h1dVQtpudJO8vpS+5sP2BM7zxGd6y5muhYttNY1pDJf/a9ho12Lqe3y+7xiCeWGtCt8i xu+nEBuBbp4awfmyc6mvtb2EujQDo7vehH6kTogHGXKe+UQGGzHTMRm5sHMJVoTdkly/ y0tBo2VrPaRep2rk4Wo0PNsMkDr+eT1cO8OvZQwruizaJnYqKQFZu+cItY2vR4D8bhch f0VLVhp06ADQVEs3X7AW5nBgoBD1vN5YTvFIJEzga6AyqcjV+AjVZZizLqGEo0i8X1K0 1rjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C4qI1sqY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v24si7029871pgn.64.2019.08.05.13.59.48; Mon, 05 Aug 2019 14:00:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C4qI1sqY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730668AbfHEU5s (ORCPT + 99 others); Mon, 5 Aug 2019 16:57:48 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41608 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730055AbfHEU5s (ORCPT ); Mon, 5 Aug 2019 16:57:48 -0400 Received: by mail-pl1-f194.google.com with SMTP id m9so36793603pls.8 for ; Mon, 05 Aug 2019 13:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=9X2wQUGD6zLRbLMDjJdPs/T0gS5tBwgXYnxhEUgwlZs=; b=C4qI1sqY5cPtC8702dZsoxLBKBli0n5d9Z9O2vEYh2ertxbu6hUXjIjZKClqm+PzXK /u4wPgoxWn7MxlkmuFAQ3VKGQT7BRUf0qo3hsFSr3qOc+U94xB1yilPpxop7lrME1vQW J92InGoXV9qe8Wetff/eGKJZJaXNkOX9al4t4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=9X2wQUGD6zLRbLMDjJdPs/T0gS5tBwgXYnxhEUgwlZs=; b=gpBoYOI8vexd38pi9MknaUWC88PkSwPrB1OD3duAFE+J+hWFycxJ8EBryn6g3i2RQe /H8B77BGtQYgE4MxCyibdCd9u0x+nqm0Tfh1xh+3qOczZUygbx7jtd8vV3SZJbu6rsH5 I6jC4u5xMe4kPHf37g1Zn317TrBahZPxOaDMUTU/57OrO3KQlLTcaaWvRPtqFNG2jcaV xZ35j/LYPQKjdOkILXI/EQugCxg1eX11HbbOrGts1TO8OpXx7PBTy1KOPWinrVZKl1g8 IdeZSbhnQjzAKm3VKSmpaVQUJLC1gqYBbjXAIEYtFeGvekgkEQAfnP1OFLAGB2nH/SLc zsEA== X-Gm-Message-State: APjAAAV+rIW/JvO2RtxPm7+QL3cSkP3olfGOIv5UW1nLlBRwR66zsiSI Vwv2X9noUcOJDUk9/gYmT1cqFg== X-Received: by 2002:a17:902:f01:: with SMTP id 1mr145799271ply.170.1565038667796; Mon, 05 Aug 2019 13:57:47 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id d8sm78607456pgh.45.2019.08.05.13.57.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 13:57:47 -0700 (PDT) Message-ID: <5d48984b.1c69fb81.325a7.e2d9@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190805175848.163558-3-trong@android.com> References: <20190805175848.163558-1-trong@android.com> <20190805175848.163558-3-trong@android.com> Subject: Re: [PATCH v7 2/3] PM / wakeup: Use wakeup_source_register() in wakelock.c From: Stephen Boyd Cc: rafael@kernel.org, hridya@google.com, sspatil@google.com, kaleshsingh@google.com, ravisadineni@chromium.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel-team@android.com, Tri Vo To: Tri Vo , gregkh@linuxfoundation.org, rjw@rjwysocki.net, viresh.kumar@linaro.org User-Agent: alot/0.8.1 Date: Mon, 05 Aug 2019 13:57:46 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Tri Vo (2019-08-05 10:58:47) > kernel/power/wakelock.c duplicates wakeup source creation and > registration code from drivers/base/power/wakeup.c. >=20 > Change struct wakelock's wakeup source to a pointer and use > wakeup_source_register() function to create and register said wakeup > source. Use wakeup_source_unregister() on cleanup path. >=20 > Signed-off-by: Tri Vo > --- Reviewed-by: Stephen Boyd