Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp3214268ybh; Mon, 5 Aug 2019 14:13:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwv4pEba7cC4KjxTm5eYM0OjV+a7EK4alax5nSKH0tG4MpczybMLZDrsxzEG9PJazrgb2j+ X-Received: by 2002:a17:90b:28f:: with SMTP id az15mr19876496pjb.18.1565039603282; Mon, 05 Aug 2019 14:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565039603; cv=none; d=google.com; s=arc-20160816; b=ee8CPTFHdpDfvN9ozJM9SZNYXyl+HW6aeY3QZ8mnPlZBMVX+qPnKqaKKj2Lwe/pP3Q AxFLEnHGAwcsrhMVAlJxptqf9i4cB4ATCxATHxErqOcgCDohsjUze/MZwhrHxARiV8JB vPC60lPJGMjEHeVp/ReWoFi5jCKQizU7yE2C/VPbp+ogcvKdgabeeWENz8KaNo2KSrQx TjnIrMtlgRRJ7eYurbfi957NP3t3vkc0rHeJNMrw21gJWHTRZXVl1Q+vjo8i0jHHmdSU aI89nVIoE3F3fddnKcbhXffDGWaGxsWIVO1e/yoGlEaPBTyCTADS1E8D3DdsDhp130TJ BQmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=52Df7UYy5EhBLL4bv/P+/OnUf70c8jTeH6mJgj5Nc6s=; b=uLoPHRD6+OjZ+1M0LLl2oAP5ohM2HY3/PQENwC5RU3OD5oXQRAo1N/eesXdpFIac0+ d98M+b7nJke0gFr++a2Htl2mX25Fs+Xc9DLM5D2OISmwDfjNIeTUxKJhpBQ71yOaUFie SMKas8WnNy6dVxa2mTgKFw4fxy2t+/BeP3erKDb/cnj7Gm6TkYGGiMsMttHug4lkdASw 0gMd81kBp3eDM7TGfCZNO2SyPjmMEJfy0l7vSQK0X121x8Gp2FvDDeTqa4Ziy7oiJwhh 5+9Y0o8XZ+Um+NyNsTkNDKB6rDcjOIv4ZTK4EntzTDEUZkTu5Jx22cNw+4E/ssVdQT3c Uibw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HvwClAPw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si5419151plb.106.2019.08.05.14.13.07; Mon, 05 Aug 2019 14:13:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HvwClAPw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730735AbfHEVMZ (ORCPT + 99 others); Mon, 5 Aug 2019 17:12:25 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:45012 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730653AbfHEVMY (ORCPT ); Mon, 5 Aug 2019 17:12:24 -0400 Received: by mail-lf1-f67.google.com with SMTP id v16so5292801lfg.11 for ; Mon, 05 Aug 2019 14:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=52Df7UYy5EhBLL4bv/P+/OnUf70c8jTeH6mJgj5Nc6s=; b=HvwClAPwJG3Pi3R4ysSHdSnZra19G+8lxf4u1AX3bm8UTIL32r5/3r4AQDUUnJ/o3L dpaHikb4ucEdmircjNP99G70agmxOPDPQMJwswRiDJ0anTMpviFli3+46wzjbxWNr1qH dghsq9SmMx3LQM+G8BVjUzYIiqSKOMRrvkiKT79W6AoIWk+5Pip47CWTOVU0kk2YNmU+ 0Izo3RTcKcBjeZveVRbI9DDa6X/mc1vAauC8y3m2avmDY+FIHe/0IazV0HkXFcr81ler t8S7rjmV2wXa1V+9Jsr6Shx95cI1Kl0lZoh/K5dH9RDgTkaryuZnjn+7/Z/NwST+Y+HQ WbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=52Df7UYy5EhBLL4bv/P+/OnUf70c8jTeH6mJgj5Nc6s=; b=Ev2tRqB59Way2lYf4JDjgsLUBdl3CJtEZNnZx8jsbg9Kto6/6z1rivhucbVRKSHX5S n2J22+bvweKVr74721VvbjIJB1mp2Qt55NdLksR0HYWfKd0h9nuAbp27F8Wwp9x1IicG gFuwYjpietLmkNTNSGKp+PGkcJsEmEkE80XQSZxs4tkiLr3EBK17aAtDpxD6hAYU6BHn A0l5YJmMRx7d8XR8XRGUyyXH7nzDKgQ2q/+UlYIDi6o9Kh5IMMyV4H3TGUDL9mhlDI4M DPmj1/6IMaIVrV0Got+rA0o+XU0tKH2I+3JwKkk2jg+AnGxYBGId/GcyMZauuddJ57J3 1nUw== X-Gm-Message-State: APjAAAUfMvCfJFnTOs9YeDFgm7Q69O4eD0h0Pm/FjfI9dNrWkU6cqMVx GkyNL1Xcan27OS1ske6DTnI3u7AEmti6DOW6rRx1vg== X-Received: by 2002:a19:e006:: with SMTP id x6mr71138714lfg.165.1565039542766; Mon, 05 Aug 2019 14:12:22 -0700 (PDT) MIME-Version: 1.0 References: <20190724082508.27617-1-brgl@bgdev.pl> In-Reply-To: <20190724082508.27617-1-brgl@bgdev.pl> From: Linus Walleij Date: Mon, 5 Aug 2019 23:12:10 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] backlight: gpio: simplify the driver To: Bartosz Golaszewski Cc: Yoshinori Sato , Rich Felker , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Andy Shevchenko , linux-sh@vger.kernel.org, "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-fbdev@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 24, 2019 at 10:25 AM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local vars The series: Reviewed-by: Linus Walleij Yours, Linus Walleij