Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 6 Aug 2019 12:15:19 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Cc:     Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thiago Jung Bauermann <bauerman@linux.ibm.com>,
        Philipp Rudo <prudo@linux.ibm.com>,
        Jessica Yu <jeyu@kernel.org>
Subject: linux-next: build failure after merge of the integrity tree
Message-ID: <20190806121519.0f8ac653@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/zTLvc.ANXYxn/G.A9CglH=f";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/zTLvc.ANXYxn/G.A9CglH=f
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the integrity tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from <command-line>:
include/linux/module_signature.h:32:2: error: unknown type name 'u8'
  u8 algo;  /* Public-key crypto algorithm [0] */
  ^~
include/linux/module_signature.h:33:2: error: unknown type name 'u8'
  u8 hash;  /* Digest algorithm [0] */
  ^~
include/linux/module_signature.h:34:2: error: unknown type name 'u8'
  u8 id_type; /* Key identifier type [PKEY_ID_PKCS7] */
  ^~
include/linux/module_signature.h:35:2: error: unknown type name 'u8'
  u8 signer_len; /* Length of signer's name [0] */
  ^~
include/linux/module_signature.h:36:2: error: unknown type name 'u8'
  u8 key_id_len; /* Length of key identifier [0] */
  ^~
include/linux/module_signature.h:37:2: error: unknown type name 'u8'
  u8 __pad[3];
  ^~
include/linux/module_signature.h:38:2: error: unknown type name '__be32'
  __be32 sig_len; /* Length of signature data */
  ^~~~~~
include/linux/module_signature.h:41:54: error: unknown type name 'size_t'
 int mod_check_sig(const struct module_signature *ms, size_t file_len,
                                                      ^~~~~~
include/linux/module_signature.h:41:54: note: 'size_t' is defined in header=
 '<stddef.h>'; did you forget to '#include <stddef.h>'?
include/linux/module_signature.h:1:1:
+#include <stddef.h>
 /* SPDX-License-Identifier: GPL-2.0+ */
include/linux/module_signature.h:41:54:
 int mod_check_sig(const struct module_signature *ms, size_t file_len,
                                                      ^~~~~~

Caused by commit

  c8424e776b09 ("MODSIGN: Export module signature definitions")

We now have build time checks to make sure that include files are self
contained.

I have added the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 6 Aug 2019 12:09:36 +1000
Subject: [PATCH] MODSIGN: make new include file self contained

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/module_signature.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/module_signature.h b/include/linux/module_signat=
ure.h
index 523617fc5b6a..7eb4b00381ac 100644
--- a/include/linux/module_signature.h
+++ b/include/linux/module_signature.h
@@ -9,6 +9,8 @@
 #ifndef _LINUX_MODULE_SIGNATURE_H
 #define _LINUX_MODULE_SIGNATURE_H
=20
+#include <linux/types.h>
+
 /* In stripped ARM and x86-64 modules, ~ is surprisingly rare. */
 #define MODULE_SIG_STRING "~Module signature appended~\n"
=20
--=20
2.20.1

--=20
Cheers,
Stephen Rothwell

--Sig_/zTLvc.ANXYxn/G.A9CglH=f
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1I4rcACgkQAVBC80lX
0Gzw6gf+KRVWNfz612RsV41gpCJO04MKJt5O2JENYUhAKLQUOEKgF7EyYuN4sxk3
2o26m2vt40nBv4qXgGc1aKwqnqz7SFuIijzc/wxCh2SoJISI/F2MjXunF9PmxIwN
Z5bjxxZUhgB7z83evNe5kEstS3W9iV4N2cAJkU8cMDed9CehFkFUsN06JZgfoysD
i2pNOFSOS9IJcYttRIk1e1C+H5su5JgErSv5zteQFzG3vCDsmgWfPLN92kBTT9MO
H/tdeAVx/hn9aLj6gpfOtggtrbQkFgc5Oj8zEsi8MfBwzdrW8Fnymjuc7subdtWp
7W8XouRhQTa0rls3sPu6sOMydiIk6w==
=Qd6n
-----END PGP SIGNATURE-----

--Sig_/zTLvc.ANXYxn/G.A9CglH=f--