Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp3718155ybh; Tue, 6 Aug 2019 00:06:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqykbhErUZQvn8zEVXHoWVXE+0l8Y+Tx2OWnQgCas9BLJlQNY+ECOkxZfozAFVM4/OSnYUCJ X-Received: by 2002:a17:902:9349:: with SMTP id g9mr1712249plp.262.1565075214427; Tue, 06 Aug 2019 00:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565075214; cv=none; d=google.com; s=arc-20160816; b=Vf6EmHsofAG/9wX24u/4/9xfIqjMJPlgGFWz4KiWzJiTk2C+EZvOamlsP4PLXnP/Sf GlZNjhjTFx8LkVtdkTn2tmW2b/3kSvDrQB0mQpLgtxwNacMmQqxxs1XYXc9Q8H8hKIhM datNMo07wGwrgWH8bZjK0oT5S69IEXUan/d9PlHOsYRzu6V5Zg+1QJV8UPFMMygm1EgR oqBVBloVxapoP08FU969cJB86PskmuC8rxjSVMncDsUIN6U4rSZDbXtfpMtGO4dzma0j cdfrZAR4UxbbOID8miNeRoXbVRFXE0s2PmOrPBJmPMU3ZKR8JndEiqzH+UI1Qp/drNKu kPyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=nvNLdWRzNCcP/1tMguZTrB/Ret9xhkOHTVDfmzeadKU=; b=DHa+VcFMMahIhQyhLUbhkn+7kbtcrWdJMDKXbt603yQEQ2KhAFB/CXwCv8963sDick 8wVJYjo3rzvj/PCGavBROZei8sVfztok5h99qHl/+jz8xsqTRcGeMkp2LVYcN6OGQfwQ aQxHotPFY0glvCzv2wwisR2kOyzuIxwDf1xiBCKoUpl3HDriPvl+iNHKnYY53EhdkTM9 mDPmZTMQCjHyRx1LiPM7efdxtDbFQ0BgR++GTTDDT7zut/cDykwEwy+m6cewdJTBNaig KlCJcyHzdOK6jZv4Lu4iflBkRRKd4xHgZ3S49Q+UstlQzjRmwRJslsqJdX8QYvVqe2MD GpcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=cBNuGU4D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si40622803plb.35.2019.08.06.00.06.38; Tue, 06 Aug 2019 00:06:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=cBNuGU4D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732051AbfHFHGA (ORCPT + 99 others); Tue, 6 Aug 2019 03:06:00 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:41277 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731834AbfHFHF5 (ORCPT ); Tue, 6 Aug 2019 03:05:57 -0400 Received: by mail-vs1-f65.google.com with SMTP id 2so57599040vso.8 for ; Tue, 06 Aug 2019 00:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nvNLdWRzNCcP/1tMguZTrB/Ret9xhkOHTVDfmzeadKU=; b=cBNuGU4Dr8PNxOG4ZXsD1SeAcDdS2PkACRvfDIJni+NMYiI6xg8Z3QBrHu8RM3OnDB 8wnSQRm1UoqZt/3vMiKQ90iQxecWGqvo0J+py/fnUuxiWlqxMkXHQhOG0x85badHtAHY ZreuyxdeX5OU0y20ts8cmzeJZgM3pv7EjchVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nvNLdWRzNCcP/1tMguZTrB/Ret9xhkOHTVDfmzeadKU=; b=nMhhBHdCHZapuV8ZaVkk4c5DerCRTh4TwGb1NrnjiKdAtiHCVd7HysmFXGcSQQj8YH 77rZWwSlilXv+J8invCNCtW69eIj1fiuQlG4jt831NSHhfFBowbCSfoM2Armj57s8Hhl YqmKPJi0hZ9FcAIwHwxkNrLsUuGTd4jgdJjEpfCq1nk00r/I4n2MqNDFhfaT6SaryG3x 8I/aQgRc8sUcF0Rp7R1mGpBUTwT8BAJGA3l70dtcaTGAxRWPlQN9xuucSN8WSa/cTueN PaXjUPgX6QiaR5RoHuECgTe4hcbpT7kL1kiYlIrH+1Ptlr1dxBTeQ1pLcO5MB+0iO4ox nUWg== X-Gm-Message-State: APjAAAWsVxaVLojN4+jQBZKwNZhNt5sNcDQXVCqX+i2OYaDM3hfcR9AR KPIgJgji7LaHDfvmYOFyQEZI9VdV049hsyn+oMfMrg== X-Received: by 2002:a67:f355:: with SMTP id p21mr1369725vsm.204.1565075156521; Tue, 06 Aug 2019 00:05:56 -0700 (PDT) MIME-Version: 1.0 References: <1564151143-22889-1-git-send-email-cai@lca.pw> In-Reply-To: <1564151143-22889-1-git-send-email-cai@lca.pw> From: Sumit Saxena Date: Tue, 6 Aug 2019 12:35:45 +0530 Message-ID: Subject: Re: [PATCH] scsi/megaraid_sas: fix a compilation warning To: Qian Cai Cc: "Martin K. Petersen" , "James E.J. Bottomley" , Kashyap Desai , Shivasharan Srikanteshwara , "PDL,MEGARAIDLINUX" , Linux SCSI List , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2019 at 7:55 PM Qian Cai wrote: > > The commit de516379e85f ("scsi: megaraid_sas: changes to function > prototypes") introduced a comilation warning due to it changed the > function prototype of read_fw_status_reg() to take an instance pointer > instead, but forgot to remove an unused variable. > > drivers/scsi/megaraid/megaraid_sas_fusion.c: In function > 'megasas_fusion_update_can_queue': > drivers/scsi/megaraid/megaraid_sas_fusion.c:326:39: warning: variable > 'reg_set' set but not used [-Wunused-but-set-variable] > struct megasas_register_set __iomem *reg_set; > ^~~~~~~ > Fixes: de516379e85f ("scsi: megaraid_sas: changes to function prototypes") > Signed-off-by: Qian Cai Acked-by: Sumit Saxena > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c > index a32b3f0fcd15..e8092d59d575 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c > +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c > @@ -323,9 +323,6 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance, > { > u16 cur_max_fw_cmds = 0; > u16 ldio_threshold = 0; > - struct megasas_register_set __iomem *reg_set; > - > - reg_set = instance->reg_set; > > /* ventura FW does not fill outbound_scratch_pad_2 with queue depth */ > if (instance->adapter_type < VENTURA_SERIES) > -- > 1.8.3.1 >