Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
To:     fugang.duan@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc:     gregkh@linuxfoundation.org, kernel@pengutronix.de,
        festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20190704142032.10745-1-fugang.duan@nxp.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <65afeaaf-f703-02f2-a918-90a8bb8f58b6@linaro.org>
Date:   Tue, 6 Aug 2019 11:03:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190704142032.10745-1-fugang.duan@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 04/07/2019 15:20, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
> 
> i.MX8QM efuse table has some difference with i.MX8QXP platform,
> so add i.MX8QM platform support.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>   drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
> index be2f5f0..0d78ab4 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -16,6 +16,7 @@
>   
>   enum ocotp_devtype {
>   	IMX8QXP,
> +	IMX8QM,
>   };
>   
>   struct ocotp_devtype_data {
> @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
>   	.nregs = 800,
>   };
>   
> +static struct ocotp_devtype_data imx8qm_data = {
> +	.devtype = IMX8QM,
> +	.nregs = 800,
> +};
> +
>   static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
>   				     u32 *val)
>   {
> @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = {
>   
>   static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
>   	{ .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
> +	{ .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
>   	{ },

Looks like you forgot to add this new compatible to device tree bindings 
at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to 
add me to CC.

Please resend the patch with it, I can not apply this as it is.

Thanks,
srini

>   };
>   MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
>