From: David Howells <dhowells@redhat.com>
To: nathans@sgi.com, hch@infradead.org
cc: linux-xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: XFS accessing arch-specific structures
Date: Mon, 12 Dec 2005 14:39:12 +0000
Message-ID: <25190.1134398352@warthog.cambridge.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1203
Lines: 32


Hi Nathan,

I've got a problem in which XFS is accessing arch-specific structures, and
thus requiring those structures to conform to its ideals. Specifically, it's
trying to read the counter using atomic_read(), whether or not this is
possible:

    fs/xfs/linux-2.6/sema.h:
    #define valusema(sp)			(atomic_read(&(sp)->count))

    compile log:

      CC      fs/xfs/xfs_inode.o
      CC      fs/xfs/xfs_inode_item.o
    fs/xfs/xfs_inode_item.c: In function `xfs_inode_item_pushbuf':
    fs/xfs/xfs_inode_item.c:803: error: structure has no member named `count'
    fs/xfs/xfs_inode_item.c:825: error: structure has no member named `count'

Can you fix this please? This will not compile with all archs.

I'm told that Christoph Hellwig may have an idea or a patch that might provide
a fix. If it's necessary to get the count on the semaphore (which it might
be), then you should add a function to each asm/semaphore.h to retrieve it and
use that.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/