Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbVLLO4s (ORCPT ); Mon, 12 Dec 2005 09:56:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751260AbVLLO4s (ORCPT ); Mon, 12 Dec 2005 09:56:48 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:64924 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S1751252AbVLLO4r (ORCPT ); Mon, 12 Dec 2005 09:56:47 -0500 To: Miklos Szeredi Cc: schwab@suse.de, akpm@osdl.org, linux-kernel@vger.kernel.org, pj@sgi.com, rth@twiddle.net, davej@redhat.com, zwane@arm.linux.org.uk, ak@suse.de, ashok.raj@intel.com Subject: Re: [PATCH] move pm_power_off and pm_idle declaration to common code References: From: ebiederm@xmission.com (Eric W. Biederman) Date: Mon, 12 Dec 2005 07:54:52 -0700 In-Reply-To: (Miklos Szeredi's message of "Mon, 12 Dec 2005 15:46:57 +0100") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 28 Miklos Szeredi writes: >> >> Does powerpc still build? A key question is how do we handle architectures >> >> that always want to want to call machine_power_off. >> > >> > I didn't (and can't) check, but it should. IIRC multiple declaration >> > of a variable is OK, as long as at most one has an initializer. >> >> And as long as you don't build with -fno-common. > > That seals the argument, since -fno-common is in linux/Makefile. > > So the patch wants fixing on powerpc, but I don't feel up to the task. > > Somebody with better knowledge of that arch? It isn't just powerpc, alpha at least wants this behavior as well. So until someone comes up with something better I am going to recommend we fix the arches one at a time so we can actually audit them and see what needs doing. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/