Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4302816ybh; Tue, 6 Aug 2019 09:22:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+oBZbVPJcg/9Pd5qtgnR/LLExLWCuiBqU39jVb/mZWmEtbvrsL0BrqSRADT5t141sZ1XC X-Received: by 2002:a65:63c4:: with SMTP id n4mr3759306pgv.44.1565108569376; Tue, 06 Aug 2019 09:22:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565108569; cv=none; d=google.com; s=arc-20160816; b=LubSxFEe2qU4oTNqJgEOg/nWS/jTGnMnrn4rY/Kmwl4dhCcUKDMh5/9LGSrpeKGoMz 2hiW6EQQDEMNt2f9q2FcKxgqdPmClp84ktZuGDUEGwB0yzRRO9bnOtf5pzC0vBdh6J3O 2kV+iKaculoqk3fl0O2hjcnssBWkHKNhV1148J1cYMMqQMj9oSEjNcAjM1+K08nHHlMI tJdnNkPnm7WnAIrni2oxaoSizAZVEqfT6Yn67GYXPMn71ioh85nPvIpIBhxn3DNbd5/f RCRNd/ndcKV9mUGH+d2dzCulOuH+EVYNLqyK/Tx3FrhVPj7b38se74k+FeU2DV7Wb30M /8Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:references:mime-version :in-reply-to:subject:cc:to:from; bh=ObQq2XbzvRIhDj5WrHCCltqusk8KPLC+LVBFQxr8wgg=; b=cyozwUABjx+L+KS+LlIGN1zqSAexkulieHmdz+PssDIyEHNc3B20TidUNXdNRm6jjU 8EHEtQdpnGCt6t91siiKWFNvVwLIoArH9Jfb9bRh+JQujFNPWGrHP7PrOMCUh4uZKFDc /mydkJeeox+z2bkwJLEEw0au66ILFUko/Om/G4p3WUIPR0B9qL4rVsvFtq03ZBr9VZaa cdwK2RT+UFXdgruhrWzdccy89Tu2T3Xzv4rT3++hm0P8RzX0eggaW1g8K8FXX+nMaNOX 8XvoX67zQrQnukZ6+pRnk74+Gb77Fs8aObBqxY3A/bv3y+fJgXF0O9RTd5Jmh6ZP7k4d vuRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si48680610pff.263.2019.08.06.09.22.32; Tue, 06 Aug 2019 09:22:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387596AbfHFQV6 (ORCPT + 99 others); Tue, 6 Aug 2019 12:21:58 -0400 Received: from mga04.intel.com ([192.55.52.120]:22438 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732531AbfHFQV6 (ORCPT ); Tue, 6 Aug 2019 12:21:58 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 09:21:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="374103242" Received: from ellie.jf.intel.com (HELO ellie) ([10.24.12.161]) by fmsmga006.fm.intel.com with ESMTP; 06 Aug 2019 09:21:56 -0700 From: Vinicius Costa Gomes To: Ivan Khoronzhuk , davem@davemloft.net Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: Re: [PATCH] net: sched: sch_taprio: fix memleak in error path for sched list parse In-Reply-To: <20190806100425.4356-1-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain References: <20190806100425.4356-1-ivan.khoronzhuk@linaro.org> Date: Tue, 06 Aug 2019 09:21:56 -0700 Message-ID: <871rxyqn6j.fsf@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ivan Khoronzhuk writes: > In case off error, all entries should be freed from the sched list > before deleting it. For simplicity use rcu way. > > Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler") > Signed-off-by: Ivan Khoronzhuk > --- Acked-by: Vinicius Costa Gomes