Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4312505ybh; Tue, 6 Aug 2019 09:31:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxn4FJzUtQTjRo0XQJ3+j3ywYvW9edBT55fDnZTVZSSW+tfT1Z8JUshM2CMChhVOGcHgrtU X-Received: by 2002:a17:902:a606:: with SMTP id u6mr3717654plq.275.1565109101304; Tue, 06 Aug 2019 09:31:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565109101; cv=none; d=google.com; s=arc-20160816; b=IpUnrpscQ1HfIVMd94jQ8ZMQUnVoXk2DSYihOatOLT//Xe7AUkqrdaoJMtTY7V0A+I yfp2Xp86TeMkjwOWAcvZRyjeXenxfSOzsAORmjwbDJ+JNr7BIF1YFp0Ib+dPabuugQyr s8kmJXeNkUwbTqTVFHsDrJrMw6JNAXYVGDnBZjgWdqWctxHUptmeWkXmpdX/L3HZqg2P FyAMLlhUzC4m1aSDMssLHNzFpRbbu0GulPpMbxWG/oqpirJ2vBHpBPCF8FpEfqrnS4sA w+vtQ7y2wTRtOxnX3GJXqKFmOG4CBVwXyE68Ddc4i2jClxkua0TrnMbMCXHgQl/rMbHS tVBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=l584KyE9rpCvZet0nUy/dgub6TiTca54EThUDpsiB2Y=; b=PIKN6E/CHgZB3faRp0f59C7cn2XXeuqbVqv1c7ZAVZATnjq0ypGmsOU45v0zyB0jkN aIP6Pa2wcYeug7xQRv/YY5P4Pc21AVMt2DcB5btqPhQjubLxdCyjMcAtTdKNAiHmq8MO s+xokmju/SLccZDRS/RRJFuuB6ju+wue16Hq5ye68R2Gz7jWNUuqIDNhSpTKXKZb/5C6 lI5XmhBJOmaxDUGbsPe2I01UM1GpmBuXo2kpd9b2xXf7XJDcMGpPzTOUXZR9TPeSIh0p sCbPWv7kXteskMI9iXQOJCzFkxYT12fUBv9HlmQr7HltN75wF6bQiXMutUeSmUBOC6O/ jIsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si42201118pls.183.2019.08.06.09.31.25; Tue, 06 Aug 2019 09:31:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387964AbfHFQaq (ORCPT + 99 others); Tue, 6 Aug 2019 12:30:46 -0400 Received: from mga04.intel.com ([192.55.52.120]:23275 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730265AbfHFQaq (ORCPT ); Tue, 6 Aug 2019 12:30:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 09:30:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="179200133" Received: from unknown (HELO [10.7.201.140]) ([10.7.201.140]) by orsmga006.jf.intel.com with ESMTP; 06 Aug 2019 09:30:45 -0700 Subject: Re: [PATCH V2] fork: Improve error message for corrupted page tables To: Sai Praneeth Prakhya , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , Vlastimil Babka , Peter Zijlstra , Andrew Morton , Anshuman Khandual References: <3ef8a340deb1c87b725d44edb163073e2b6eca5a.1565059496.git.sai.praneeth.prakhya@intel.com> From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= mQINBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABtEVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT6JAjgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lcuQINBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABiQIfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y Message-ID: <73b77479-cdd2-6d53-14ae-25ec4c4c3d25@intel.com> Date: Tue, 6 Aug 2019 09:30:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3ef8a340deb1c87b725d44edb163073e2b6eca5a.1565059496.git.sai.praneeth.prakhya@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/19 8:05 PM, Sai Praneeth Prakhya wrote: > +static const char * const resident_page_types[NR_MM_COUNTERS] = { > + [MM_FILEPAGES] = "MM_FILEPAGES", > + [MM_ANONPAGES] = "MM_ANONPAGES", > + [MM_SWAPENTS] = "MM_SWAPENTS", > + [MM_SHMEMPAGES] = "MM_SHMEMPAGES", > +}; One trick to ensure that this gets updated if the names are ever updated. You can do: #define NAMED_ARRAY_INDEX(x) [x] = __stringify(x), and static const char * const resident_page_types[NR_MM_COUNTERS] = { NAMED_ARRAY_INDEX(MM_FILE_PAGES), NAMED_ARRAY_INDEX(MM_SHMEMPAGES), ... }; That makes sure that any name changes make it into the strings. Then stick a: BUILD_BUG_ON(NR_MM_COUNTERS != ARRAY_SIZE(resident_page_types)); somewhere. That makes sure that any new array indexes get a string added in the array. Otherwise you get nice, early, compile-time errors.