Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4318493ybh; Tue, 6 Aug 2019 09:37:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhVvZUC8zhMjn/K3jAKuistPlQ1pL8qxeTwkdlIOb3fDijMVL8LYptdbQZCF5Eh6XpiLpf X-Received: by 2002:a63:de43:: with SMTP id y3mr3865964pgi.211.1565109440424; Tue, 06 Aug 2019 09:37:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565109440; cv=none; d=google.com; s=arc-20160816; b=dpjbsCzoVWd2TXDIEGpZhPPFR7TCWb2m/qxMNT7LlVTd+8v/kfFu0xrgw8Ui+fPM9C MURc9VugNyBdkjiHDZV//7y8/JX8BdEZWimGK7a60TdB697Iw33CP0DWdr2Zrl03N5zW B64cRVn4+Pbvtg0pF/HLx7UTYgw8kSysnGbZK1gxgqZoBGgw+jPmSbJUhYK3JAOhTkSG WaXh0LHpSdwELws3ygT7pyz8ioWLeILyk7rHDzTQbuaUBTUhMYxz3TOsgto0VCGF4BIs IX7IlPCDVHnzunLRVwOaaE7qM+un6hexPXf5Ou5l1ji9wVY7neWy3T+yECTMsl4+6SNl yGfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=KW6efSqilQNg6U93GNyeiwm1WRzrNLnADLcNRJ8/pvc=; b=DO97Dfy7LXGKRuL3KbTOOwBuu1JrzJJNdG0w8OfNqMS3I7jU51EE2giOUEiX0ZKmuu TBHGq/d6Jo7ot/3zAMtj9DwCA0FqljBJpOmmvo0AtpVGir0J/qIqFAieXqwv1GDnouAr CxSnFhRIb4N+vC2s5qnZzLpo65zNCkWOOAmX9lRUbYutAzGR/IIZ0pwvHJarK9nwwQBj IYXHBykYrb9B6YT2+i3s4hqOxzLBZJqhM0pbTpV1eu7aFfhHnm0c0BMkARnG2TdCEJ+z KCgqhZKN73Ux/e+L4PIsnxp1yxBFjVhsM08q5wot9HO9W4cwvMKHgNiTBjlgm43nW3J5 VdQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f139si77474422pfa.2.2019.08.06.09.37.04; Tue, 06 Aug 2019 09:37:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387951AbfHFQf1 (ORCPT + 99 others); Tue, 6 Aug 2019 12:35:27 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:56360 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726877AbfHFQf0 (ORCPT ); Tue, 6 Aug 2019 12:35:26 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0D6F1403823FB709DEE3; Wed, 7 Aug 2019 00:35:24 +0800 (CST) Received: from [127.0.0.1] (10.202.227.238) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Wed, 7 Aug 2019 00:35:22 +0800 Subject: Re: [PATCH] docs: mtd: Update spi nor reference driver To: , , References: <1565107583-68506-1-git-send-email-john.garry@huawei.com> CC: , , From: John Garry Message-ID: <6c4bb892-6cf5-af46-3ace-b333fd47ef14@huawei.com> Date: Tue, 6 Aug 2019 17:35:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1565107583-68506-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2019 17:06, John Garry wrote: > The reference driver no longer exists since commit 50f1242c6742 ("mtd: > fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c"). > > Update reference to spi-fsl-qspi.c driver. > > Signed-off-by: John Garry > > diff --git a/Documentation/driver-api/mtd/spi-nor.rst b/Documentation/driver-api/mtd/spi-nor.rst > index f5333e3bf486..1f0437676762 100644 > --- a/Documentation/driver-api/mtd/spi-nor.rst > +++ b/Documentation/driver-api/mtd/spi-nor.rst In fact this document has many references to Freescale QuadSPI - could someone kindly review this complete document for up-to-date accuracy? Thanks, John > @@ -59,7 +59,7 @@ Part III - How can drivers use the framework? > > The main API is spi_nor_scan(). Before you call the hook, a driver should > initialize the necessary fields for spi_nor{}. Please see > -drivers/mtd/spi-nor/spi-nor.c for detail. Please also refer to fsl-quadspi.c > +drivers/mtd/spi-nor/spi-nor.c for detail. Please also refer to spi-fsl-qspi.c > when you want to write a new driver for a SPI NOR controller. > Another API is spi_nor_restore(), this is used to restore the status of SPI > flash chip such as addressing mode. Call it whenever detach the driver from >