Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4386190ybh; Tue, 6 Aug 2019 10:46:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6mktZ0cPDHFL3P0w46wNm3a/LJdQ88LxcJTVkQ8n6o5WOwrm4QukEmq5D9fWzHVmOO4ds X-Received: by 2002:a65:6495:: with SMTP id e21mr4075142pgv.359.1565113561179; Tue, 06 Aug 2019 10:46:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565113561; cv=none; d=google.com; s=arc-20160816; b=Qf/z5r9/y64dy+VaJJMOrSsJjxFYHjHC2ul0cXfEEVTPA2n8avNwuWuJ7r9ZfXPd60 vjIcyAQDY/cgEPNnDHyuXlkgY+TnrZwjcs9eRJKfUDZZYQjsLthv2m8vBMkLrhJPJOdz 7VAwt+eba72KXDa2rgQGPE6kwP63KAT6VVGl1N5r+G/3f3OeppKSjT0VInLsWCN7QJkp HDc9gcyMhyipvKkXnm+F/74txjFlHai4A4XV7VgGyfXmRrMvDoTNhXuX2Qkgv7Ie+I0e oSvMIHNtq/CaubgRPhd+ZPqHAQNVIV3l1Hr9UKu8EDChXDgRDh2Ikm73SKlBwxVgUEto O/EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MYkGzGBuQSIWtSoa+slPGOLaQ8BEFqSf3UAwSnHf9G4=; b=ucFSPjQ3GUOXgdf70DiFGgvzjSJ8/jdI8FKkNE74J51oRuzggmL6e9/qHVuNAuOMPd r2rxSQJH7YlesCoD9EfuHaq4PefANPUySIkdgMr9AMFmcvyxwEYHr0RXsa7ZoJ/nogk1 gPaYHA86zCQM4DkONkkVDpV6RrT9Wvqg5udDO1Aa+jZkBhp35G0FTedFfN7adY915OuH 046FgVsFa6A+e5p8RIRmWPR9kgQqyN9M7zLbFYeaWIDcO58n4iXDn6odrVzACc7K7BTi LdTM6ZJql1HWL4ENxuXSrpLfZOOpDdSv99jsvrT3wT72y7rIQZsgOqOzEoBGmHTgZ2Rf pUVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=T2GiLCQi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si44604933plp.229.2019.08.06.10.45.45; Tue, 06 Aug 2019 10:46:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=T2GiLCQi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732037AbfHFP5W (ORCPT + 99 others); Tue, 6 Aug 2019 11:57:22 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37798 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfHFP5W (ORCPT ); Tue, 6 Aug 2019 11:57:22 -0400 Received: from zn.tnic (p200300EC2F0DA000B4A7A08B15BB062F.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:a000:b4a7:a08b:15bb:62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 38BEA1EC0C31; Tue, 6 Aug 2019 17:57:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565107041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=MYkGzGBuQSIWtSoa+slPGOLaQ8BEFqSf3UAwSnHf9G4=; b=T2GiLCQi8RmwrBEmQAGcFFplqm0t62rzP3MRUBSH59lq516QK1GaGzPqsByRGY3AYfwDvy GNPmcPI29QX8FXMfCV2yH4xW5sj36FMQ6GGPVUDNOCzZIQs0zuPdKBsPbioaBwXakaRQe2 47oo9UqkOcgyX0okXiDPbnuWCWGHflA= Date: Tue, 6 Aug 2019 17:57:16 +0200 From: Borislav Petkov To: Reinette Chatre Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com, kuo-lang.tseng@intel.com, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 01/10] x86/CPU: Expose if cache is inclusive of lower level caches Message-ID: <20190806155716.GE25897@zn.tnic> References: <6c78593207224014d6a9d43698a3d1a0b3ccf2b6.1564504901.git.reinette.chatre@intel.com> <20190802180352.GE30661@zn.tnic> <20190803094423.GA2100@zn.tnic> <122b005a-46b1-2b1e-45a8-7f92a5dba2d9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <122b005a-46b1-2b1e-45a8-7f92a5dba2d9@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 10:57:04AM -0700, Reinette Chatre wrote: > What do you think? Actually, I was thinking about something a lot simpler: something along the lines of adding the CPUID check in a helper function which rdt_pseudo_lock_init() calls. If the cache is not inclusive - and my guess is it would suffice to check any cache but I'd prefer you correct me on that - you simply return error and rdt_pseudo_lock_init() returns early without doing any futher init. How does that sound? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.