Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4471114ybh; Tue, 6 Aug 2019 12:14:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqw++S+6yebwUr8Dvi223MUrs08gZpT8RoFG3TcuhlqCySuUIEC+JV0zsl4yqAkS/fC8GcLZ X-Received: by 2002:a17:902:7782:: with SMTP id o2mr4707977pll.12.1565118849012; Tue, 06 Aug 2019 12:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565118849; cv=none; d=google.com; s=arc-20160816; b=T5hnA0JxW9rJRTNDoktHBnmiSOgvsGtEUwlz0ZqffJIB/mz//H6TLN3hFp8esw9WSx hnhey7SHP0FGjp5w+/OeFc1BazwEmmg+QrJcrMDw04D/mQMF5Tifft5BGAdYXa414bMS pDT+A5QHcWQQKvKMvlGXEh2em0dUnG+sfbASOw85i9gaKlxDcdXAo1cAFqBgRm42aFXy +P5eEhSJXas4XhZfiH9MoyTXx5GgqivZ15hDDBzD2a/yI78NgKUn8VnheuCf1oRWCmxQ LKBrAPZ0TiRKqrjek+c+KPxVdyyFOB2KZJ3W/7pIiRDUALE7rZ0p92hauoq6L5J4rK0C i9RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=VnZDZzBAZi4D2nAqWC3qKDXkK4ME9tg6Ir4ylUba4jg=; b=q/0bCYv4c29RzogQ3OWS/EZEEIwEoGMHYE5niiPGIvs122rNmItsZdlgruR1xnoe3y rSyT1ybkkqdNOOnS3pU9c8u4QbeobKTB0cpncnoZnB0ErDC6jpo+kUskvxfypSLpuLjW VXZnJjzuEVByWNlgqznJhdELV36slh1ey7y4AyfPoh4NsLisWiQriFol9c8HaP+0ECNe lHyFuVlSGPfUzC+lE9u1qx3cTJCId7ATyV+g1/LuOm7wJ8jUZAtwxKFn0CyM8WwyH3aO mwascy5AGDHkFY0ZJfecE4ixBvkUpMYliRlK89sCjx84slMqkOOMyYn+HWv0+DtgmcEV 0okg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=SGfjoPA4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si5484159plo.193.2019.08.06.12.13.53; Tue, 06 Aug 2019 12:14:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=SGfjoPA4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbfHFTNL (ORCPT + 99 others); Tue, 6 Aug 2019 15:13:11 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:35482 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfHFTNL (ORCPT ); Tue, 6 Aug 2019 15:13:11 -0400 Received: by mail-qk1-f196.google.com with SMTP id r21so63876402qke.2 for ; Tue, 06 Aug 2019 12:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=VnZDZzBAZi4D2nAqWC3qKDXkK4ME9tg6Ir4ylUba4jg=; b=SGfjoPA4i1Mm/bTUKSTpZMu1+1qm1orBY6Je1wobz3GeFacipSg3vaAISShedMFloX LklV3gXrz4aVn2LkyVj4UGkiuug9d6vhoRh51P1R8K08xXmni+YlDqLz8dI3NLFPUtKm oXY6zQlFVCaE3xrmablLByoFZQyld45ysxfuYu+Xc5ngbYZpKCyfE+FXoPrChbqAQHHM DtLsZmCMf0xURVExyIwdvQDIWIY39E/4jCu6x3sLTdiAC3HbVr/wFL4DQJkY+DtHK78U xpyCC6A7pGy23rjcJ8F5xwjRU6ri2zszNhOdqCpClLxZzFBTnmnjXiZE5BLiiVrPSHxA AKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=VnZDZzBAZi4D2nAqWC3qKDXkK4ME9tg6Ir4ylUba4jg=; b=mUoHcRaNtRy8UDcyv3sRiqQsK2n5qmZqdGIIgLtouEev0RJJ0Ss/ws6Ls4ixhXoHQU vdkSsxGIWbvpL+0q12eWSBwi73oKZHyXdcrGLgFsRR2nY3xDT7gCgXZbXta11RIp1wUc 3KGkGHE6RZ3uyiqkXrj6Q1Lh5SKrm3j7PBxQ+fc97e7GQtHMBIDmCN7ca9u+Td1ilQEl CP4p8qh0YnUVw9aNSfj84VGY1PBmXXgxAm6cNjvf97UjYPVX2XB2z+U43gqWu9DC3FC1 TYO27NnyPnOwuQzoaCZSBNh2E2oQuIFV+SfiHOkWha/jodhpUX9le3/2iKYVgjrnN5uc fzHQ== X-Gm-Message-State: APjAAAVVE9b/2YxLK8dIsCBSUA4P6+z2SmDWY6UZ21KT1nI04oqOEzvG D5OUUsW78BIDSjSaK4FopAYvuh9TIh0= X-Received: by 2002:a37:311:: with SMTP id 17mr4499484qkd.466.1565118790235; Tue, 06 Aug 2019 12:13:10 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z19sm40441271qtu.43.2019.08.06.12.13.08 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 12:13:10 -0700 (PDT) Date: Tue, 6 Aug 2019 12:12:42 -0700 From: Jakub Kicinski To: Dexuan Cui Cc: "netdev@vger.kernel.org" , "David S. Miller" , Haiyang Zhang , Stephen Hemminger , "sashal@kernel.org" , KY Srinivasan , Michael Kelley , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , vkuznets , "marcelo.cerri@canonical.com" Subject: Re: [PATCH net] hv_netvsc: Fix a warning of suspicious RCU usage Message-ID: <20190806121242.141c2324@cakuba.netronome.com> In-Reply-To: References: Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Aug 2019 05:17:44 +0000, Dexuan Cui wrote: > This fixes a warning of "suspicious rcu_dereference_check() usage" > when nload runs. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Dexuan Cui Minor change in behaviour would perhaps be worth acknowledging in the commit message (since you check ndev for NULL later now), and a Fixes tag would be good. But the looks pretty straightforward and correct!