Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4629532ybh; Tue, 6 Aug 2019 15:11:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhlCYGq+vk446zYrXo5lr9xCQtNVIyuOVVyEKwOEzv5LjqSp5dlvmpFMakQj5gc5ZVAHr0 X-Received: by 2002:aa7:9359:: with SMTP id 25mr5761170pfn.261.1565129488844; Tue, 06 Aug 2019 15:11:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565129488; cv=none; d=google.com; s=arc-20160816; b=E3DYnqAaGn2p2dUo3LDcmV+pNqVRJtJzgTjgJY1/qXoWp4eUHqyRjvV1WzGFKfhMHE wejR/GOUXm4aeGexQDnZy6HmMr2KVsu7ZZi8/rN+fWJoIqvt8nb0A8ArK3Tx7MOo0iNk BNF/18C2xVWRQ4AYvSlKKasBLhFHlcoUws4hGStHpGLCE6id5DWcc9h/GOjbjOvV4Jap R2pLPAb4oCW0QAwG8r3DUsdHm3hQWciJUg+N10TTFO+T28oRNl/VMKGpxRW8YkPH3cpw bWe/JZBY/2AgdVW9M2201GW6ABl9RlWE5/nIauM2hWZ3mpIl5reZ2A91KsHvcPwNSrJ1 9QiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=k5MlzirpZYamcdWz7AWbdCMy4iWhcebC9AZ/B4iX4vQ=; b=h1UwI1WaVGrV/pczv6ded2Evy2Jvutu5XD6CuLQu7fxeECBMVdRWZc4rPwG1YJFIPw e3EeFdiD4gEXYdvfpoYDQz/YVMsbSmJJx6igR22XAQtr4WFy9p7be5Bh7HMcOCZB6geR vQuf8YrY9lkpfv/TJKNy4/UFSbt4EGrKeRXqBkq2aoOmm6iFDF8cxgIF2yfvk5J3rbKT YTYmoqOVzH7QyFfquUKgmg2+sD2q0JDrhc7/YzeEAoHnUVAlCpgG6HWrgbN6dQAOJjTu Dait1qrJ4fyTlON4dDH4eguNrd+oCOM1xTuw2hgEbKzXqtRsNzsq3vUtFHk3gO03PqU8 D0MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=DiNlS0lM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si49840195pfi.48.2019.08.06.15.11.12; Tue, 06 Aug 2019 15:11:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=DiNlS0lM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfHFWKe (ORCPT + 99 others); Tue, 6 Aug 2019 18:10:34 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:41440 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727261AbfHFWKe (ORCPT ); Tue, 6 Aug 2019 18:10:34 -0400 Received: by mail-qt1-f193.google.com with SMTP id d17so7364656qtj.8 for ; Tue, 06 Aug 2019 15:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=k5MlzirpZYamcdWz7AWbdCMy4iWhcebC9AZ/B4iX4vQ=; b=DiNlS0lMBqKQ8N8XEC9ggrn/qkh+UA2hvtCs3VnCp/1FDuRFh8AWh0IrPMQTSI1seh ILTlQ69cQuC8/r1/C++1zZs61I17M+qy5aejqcX8ujbltSmqJ1JxPV4twEW8bb/XA75B R2wDG0iLFvBwzqcChOWMGDsxHqs5u1o207qqjuEv/znX7OKV48xSF6SE1i9X2jzYisqS zSyAFrx2evZTUZNrvCIVwVGYMifT8jRUHFC7oRXrAH6Hf/lj4EaJLSciLzD6e6GSoyc6 KQpvphQctVTQIdodoQQq/kfH+9K0S98Umqp8zkpdkLtRZmbCCklHtYljPnaonLTZ5sEK Okug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=k5MlzirpZYamcdWz7AWbdCMy4iWhcebC9AZ/B4iX4vQ=; b=VtGz91RkmCJMFDQXbosgyELz5v+LZdjwFiSm9dRn5GYrxGio2ym+UoozEGjY5Axab5 STL4KAl2AjnRvccwaiXlEAAyWV6Y6V+K+xXWlR3F23M0v+1NT8rV74QG/CpcxrNsgBxV 1nSHCCePv3k+9h0hHLy4hTQ6ZpU+RM/EKodomLwYwiPBVZYkrmJdMZLzfSykCyiHFWRr xf+6s30+dZXqxEIVCkaya57YucKnfxak1RZ1oeyfnR5GLxNd3jnVadn3rS2KGnfJs8SJ t1h9mPesenQloqr84MZ+/k9Ii0pMJJpm9eInE1DDHv7GRp3PY7fGlH7O/Mz2JUSr0xoo HIEg== X-Gm-Message-State: APjAAAW4iQMJmkFwCxFCGPGpzJGMXNa1Edu/0eXNrlGCLgravY+szdCD IuHm1fHzQgZDWmUkYyZJRpSVXg== X-Received: by 2002:aed:3987:: with SMTP id m7mr5096695qte.56.1565129433194; Tue, 06 Aug 2019 15:10:33 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t26sm47547788qtc.95.2019.08.06.15.10.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 15:10:33 -0700 (PDT) Date: Tue, 6 Aug 2019 15:10:07 -0700 From: Jakub Kicinski To: Hayes Wang Cc: , , , Subject: Re: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically Message-ID: <20190806151007.75a8dd2c@cakuba.netronome.com> In-Reply-To: <1394712342-15778-294-albertk@realtek.com> References: <1394712342-15778-289-albertk@realtek.com> <1394712342-15778-294-albertk@realtek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Aug 2019 19:18:04 +0800, Hayes Wang wrote: > Let rx_frag_head_sz and rx_max_agg_num could be modified dynamically > through the sysfs. > > Signed-off-by: Hayes Wang Please don't expose those via sysfs. Ethtool's copybreak and descriptor count should be applicable here, I think.