Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbVLLUOZ (ORCPT ); Mon, 12 Dec 2005 15:14:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932218AbVLLUOY (ORCPT ); Mon, 12 Dec 2005 15:14:24 -0500 Received: from stat9.steeleye.com ([209.192.50.41]:22250 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S932212AbVLLUOW (ORCPT ); Mon, 12 Dec 2005 15:14:22 -0500 Subject: Re: Memory corruption & SCSI in 2.6.15 From: James Bottomley To: Linus Torvalds Cc: Brian King , Benjamin Herrenschmidt , Andrew Morton , Linux Kernel list , Paul Mackerras , Jens Axboe , SCSI Mailing List In-Reply-To: References: <1134371606.6989.95.camel@gaston> <439DC9E4.6030508@us.ibm.com> Content-Type: text/plain Date: Mon, 12 Dec 2005 14:13:51 -0600 Message-Id: <1134418432.9994.32.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 26 On Mon, 2005-12-12 at 11:55 -0800, Linus Torvalds wrote: > Indeed, that looks pretty subtle. > > James: Brian's patch looks obviously correct to me (scsi_alloc_sdev() will > have called scsi_sysfs_device_initialize() which will set up the release > function to free the queue). Yes it does ... I'll put it in the rc-fixes tree. > This code has been like that forever, though, which makes me wonder. Can > anybody see what has changed to make the bug trigger? Or is there > something I'm missing? The trigger, based on the failure path has to be a slave_alloc failure of an underlying driver (which isn't that common). This may not be visible in the dmesg traces if anyone has one, because reporting the condition is up to the driver. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/