Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4720030ybh; Tue, 6 Aug 2019 16:58:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6KVrwE9NuLv9nlpc6SJVOD0C3hZfO3Yik95vTTlK341nqBWM9i9k9siEFtnGo9oyo4S35 X-Received: by 2002:a62:640c:: with SMTP id y12mr6279958pfb.166.1565135884279; Tue, 06 Aug 2019 16:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565135884; cv=none; d=google.com; s=arc-20160816; b=MQYcboEXylANpPSPkS5nuJ/yFTGotL939ZWSmKJZeML4mGdSf0Y7M0T7N/4xpHdqIz u1pYFYemdpBG3qcNYg88rYu/UHvujlFe2Yd/eG5L51b3k7yW9efWFWSEM/4mcN8ofFjH meavvJxHVC0aXHxeg1j2Cd/7c0n7y+uIAE1Koh3gl3nA2ltewkf0wMUeL2+lJDn8QtMX XBbFsX9K2sYy1cDwasQ5ndfBqCkXzoKLsNARj9KjEfCfznDImtChgq5pWxSnpmjVp3Zt 25Lzjj+jvrPqSSBKILRM5mElIZGmk/1ktkEUoJpk1jyTAgJDbVXc+8Ch8T7yowVr31Nd zdYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jfBO9hCNqYo64ONFM6ciZWbt58m9OYqaTu2HQ9ca9Ro=; b=DbwVg6hmqF7HySeO5AqbrFl+H75wI2atZRyiU0Ak3Ofu/et55sp09wev0hO3zbDsUR 0XXHYhSxRKhhowSVaL8deb9K//Hx+y9uBDW2xEpr/oYZjhCxuNCJunA7EtYuAxhV5OAk h6D0ZzINYh8N6agW8TaT2BT4AHFUE66xYDrbJML94eg5k4k6zIpjqyyn4FobVFEA75z1 57ve4AYqI2qhh7Na9Y1JsFpq7jJG9L4ngscxTcwalyx6IaSPeaEp6LcMYHA+m2tDW0uF MhjaNnrwqWEhfpIE3p01vFTNQN73c62AOALaBBVusyKK0kwvhq7uLuE3NMPp6g7+jm2o a68Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=W8eEgM2i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e23si46528188pgv.528.2019.08.06.16.57.47; Tue, 06 Aug 2019 16:58:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=W8eEgM2i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbfHFX5M (ORCPT + 99 others); Tue, 6 Aug 2019 19:57:12 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37263 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbfHFX5M (ORCPT ); Tue, 6 Aug 2019 19:57:12 -0400 Received: by mail-wm1-f65.google.com with SMTP id f17so78100015wme.2 for ; Tue, 06 Aug 2019 16:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jfBO9hCNqYo64ONFM6ciZWbt58m9OYqaTu2HQ9ca9Ro=; b=W8eEgM2it0wryCQemd+9sTsxohxFSftJHniJZ5Qr1hletzTU3TNMP1w2zUH/hfEuyL 0au0nFicRsBByjUVgItZ0FtKdIpaCavvW1sRv2pm8h3YDr6nL2e8gnVavWNGVQpWip/T 5mI7nVfekdb19B4eyRMnImDBHWb0FMcuYpX5A97FOG6afLhCWQb+V7KsuMdmM8CJgMTj gY58iFdklW31tLr8gjYOP6HV4zZtOWxNsDsPPtFNu0t4Qs97YGVrncp3eRuqu5RfuI2l LELLaXTY4KdsSWOpYJSSqfhMOT0S3g+8iQK0nNIljP4ioEqsDzwKUjIFNI4cl1v+ZBzQ eBjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jfBO9hCNqYo64ONFM6ciZWbt58m9OYqaTu2HQ9ca9Ro=; b=i0+3YIfww5FLuplIhIRRGNqtzGKktmApU9UgCvDoIKtg70BCi8PW1Qvx7pbj/lHF/8 EIzF0zQaW/HXF+/Q4QwCjE5p3ilWIFims00rh8CbSJ8tNMmTtkzFmuOR9sXshDQTO7rj /C3/+QhBr9AxhZjCodSZwTIZPSfYnKbdN3SBhRqxJXoCrUxtlBFNzmrALt8GU5hX111j tCGbTSg9+4mkXCYUawXuEoojp4xWScFXH6Vl+rNHGZmTFkPCJNE9XSJd0Vj6OCeGX2tI VnLfOJQwC9iyWHEhZHztBccP9YpbvywNcokSI+DkwczhANdy0QCE675lymdWbtFg1BD1 U7vw== X-Gm-Message-State: APjAAAX/FzzoQe+H9T6BXTRPW51y0sJMLVgiAAfyT/JQMA0otRggA/Rx xksIsoDfvriYn26mSKB2+G4xpQ== X-Received: by 2002:a1c:4b0b:: with SMTP id y11mr7085231wma.25.1565135830388; Tue, 06 Aug 2019 16:57:10 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e751:37a0:1e95:e65d]) by smtp.gmail.com with ESMTPSA id b19sm63982440wmj.13.2019.08.06.16.57.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 16:57:09 -0700 (PDT) Date: Wed, 7 Aug 2019 00:57:08 +0100 From: Alessio Balsini To: Joel Fernandes Cc: "open list:BLOCK LAYER" , LKML , Jens Axboe , dvander@gmail.com, Yifan Hong , Greg Kroah-Hartman , "Cc: Android Kernel" Subject: Re: [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl Message-ID: <20190806235708.GA10161@google.com> References: <20190806220524.251404-1-balsini@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joel, I was considering the rationale for this patch totally strightforward: it enables Direct I/O ioctl to 32 bit processes running on 64 bit systems for compatibility reasons, as for all the other lo_compat_ioctl commands. Also the reason why someone would decide to use Direct I/O with loop devices is well known, that is why the feature exists :) So I thought this was another redundant information to put in the commit message and decided to omit it. If you still think that I should update the commit message with this information, I will do so. Thanks again, Alessio On Tue, Aug 06, 2019 at 06:25:42PM -0400, 'Joel Fernandes' via kernel-team wrote: > Hi Alessio, > > On Tue, Aug 6, 2019 at 6:05 PM Alessio Balsini wrote: > > > > Export LOOP_SET_DIRECT_IO as additional lo_compat_ioctl. > > The input argument for this ioctl is a single long, in the end converted > > to a 1-bit boolean. Compatibility is then preserved. > > > > Cc: Jens Axboe > > Signed-off-by: Alessio Balsini > > This looks Ok to me, but I believe the commit message should also > explain what was this patch "fixing", how was this lack of an "export" > noticed, why does it matter, etc as well. > > thanks, > > - Joel > > > > --- > > drivers/block/loop.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > > index 3036883fc9f8..a7461f482467 100644 > > --- a/drivers/block/loop.c > > +++ b/drivers/block/loop.c > > @@ -1755,6 +1755,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode, > > case LOOP_SET_FD: > > case LOOP_CHANGE_FD: > > case LOOP_SET_BLOCK_SIZE: > > + case LOOP_SET_DIRECT_IO: > > err = lo_ioctl(bdev, mode, cmd, arg); > > break; > > default: > > -- > > 2.22.0.770.g0f2c4a37fd-goog > > > > -- > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >