Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Aug 2019 11:50:43 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: socinfo: Annotate switch cases with fall
 through
Message-ID: <20190807115043.2ff429c1@canb.auug.org.au>
In-Reply-To: <20190807012457.16820-1-bjorn.andersson@linaro.org>
References: <20190807100803.63007737@canb.auug.org.au>
        <20190807012457.16820-1-bjorn.andersson@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_//799VrEy/0lurErM4DPjHtu";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_//799VrEy/0lurErM4DPjHtu
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Bjorn,

On Tue,  6 Aug 2019 18:24:57 -0700 Bjorn Andersson <bjorn.andersson@linaro.=
org> wrote:
>
>  				   qcom_socinfo->dbg_root,
>  				   &qcom_socinfo->info.raw_device_num);
> +		/* Fall through */
>  	case SOCINFO_VERSION(0, 11):
> +		/* Fall through */
>  	case SOCINFO_VERSION(0, 10):
> +		/* Fall through */
>  	case SOCINFO_VERSION(0, 9):

I don't think you need the comment between consecutive "case"s - just
where there is actual code.

--=20
Cheers,
Stephen Rothwell

--Sig_//799VrEy/0lurErM4DPjHtu
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1KLnMACgkQAVBC80lX
0GyYUQgAgzzUeMJddV/IvgpdCqEA3DrLLwJkuL0zJW6B0gG6S6UusJz2JnB8oEO+
fN5N0Pgva4PpbOV//MBuaC3ITwQBW2mTFAqysPl1dhQaQYRA1R7EvY/wbqZ2vZB2
VOS4KyggeFeFe4PAVvhfzFp0BYUI/u4n4ZCCAhr5EMHgBnv4BXRpno2ufy9sQi+A
7G/pnMqIBhz7p5JJnz2G3QQpFfohrM0ewG6gezNf0toi9Wxyes32+GGVRXWjeQ3H
PWGJSvdZnrMAprePhDrcNzUH/OFlj3DnYMSTqA+JFoOK+bIVh5rfX/juSJ6tGzSx
2G5iR0mdMAAPfXqrg58w3vBXiA+PXQ==
=+k0V
-----END PGP SIGNATURE-----

--Sig_//799VrEy/0lurErM4DPjHtu--