Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp5256142ybh; Wed, 7 Aug 2019 03:17:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMdOeONNxgfuMR0gKtejSaAFDo5uTThfM0rqDRtG+8lkmtm6Wt4oFq7XRr8rmj4WGdS4dr X-Received: by 2002:a63:5a4d:: with SMTP id k13mr6904448pgm.174.1565173049298; Wed, 07 Aug 2019 03:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565173049; cv=none; d=google.com; s=arc-20160816; b=Oaj9hJoihxz8WV+daIY26UqMtHkXRZhLKNQOGvMTY73Kvh7hh5vfQt8Lsqjm1aA1Ly LgAW9/eqycehFcNlYMNNBVRg8v5vHv4xMpMUUzyj8UZQ9AqTuOzafdNzk7FWohiXGoEe kid8aaBggqokT/Ht3hAYknXHKxEjMn10cZH+VL7+mvBWR4BeJDrzXyosY392NO2yFjw5 SKmTXCi14k3kERiL6QFLYW6BxWR2KnmgxyLzuy1Y4kEHLf2vzxengbgt8gMuv2+jML3w zxRyPW6Gq7OyUvKMcjhajNuc5/DEGMmm+rrfgm6JclfWp5CTZo2JnISg0MPY21snWJp+ YFNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=9oORX1EHfU66HJJWdqO3JO46G9J6TCyRuReBJw2MzFM=; b=b2xLq0mFfuEmj0jKmmVo9sLkPUJnp3Ag4/0po5k/7yGkt0dGHacyCMoxESpfj0ljtW BZRFvpTD0yHhy680Il94e5HFT2XjZEz0blIr/93nX0u6xGv+VtM8eaTBlJOW6tTiC1te gCJR+UrMYqDis4ZqtT/htSuMOdQwxmtLW4ignpB0uNRnjt2NCxlFzeLJT6YtJaWDg6Ws +2XoXO0D1aUN9Vc9PMsEwnCs2Q+EN49d7JiF6DItPGtEj6DVSChjTb4ewkkOqHyU4kFQ 3p//3HPjpOv9ohhFC9TG9p8GCWssPaetiaPi4CqBKxiFywE963qoO6BCy0hVZjEd8n7v 9ljw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7si48207027pga.439.2019.08.07.03.17.13; Wed, 07 Aug 2019 03:17:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbfHGKQE (ORCPT + 99 others); Wed, 7 Aug 2019 06:16:04 -0400 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:33083 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbfHGKQE (ORCPT ); Wed, 7 Aug 2019 06:16:04 -0400 Received: from [IPv6:2001:983:e9a7:1:9c05:4bbc:890e:7747] ([IPv6:2001:983:e9a7:1:9c05:4bbc:890e:7747]) by smtp-cloud9.xs4all.net with ESMTPA id vIz9hkTa7AffAvIzBh7ksg; Wed, 07 Aug 2019 12:16:01 +0200 Subject: Re: [PATCH v4 0/3] DCMI bridge support To: Hugues Fruchet , Alexandre Torgue , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Benjamin Gaignard , Yannick Fertre , Philippe CORNU , Mickael GUENE References: <1564577783-18627-1-git-send-email-hugues.fruchet@st.com> From: Hans Verkuil Message-ID: <28a2a9ac-d5b9-a312-616a-620e0385cf66@xs4all.nl> Date: Wed, 7 Aug 2019 12:15:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1564577783-18627-1-git-send-email-hugues.fruchet@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfCP9LqKEIJwW0pIhFdbw6tGpB9o9mbS/qErOZQWhGe5Bzq7r6mVey37KBsvPv5vRS+rwW4N5qvZSOS4HYAHC9TbGd7KxoLiLiXGiTEb4+kK7x5xBPXQF BEKx6sgrIvZ0Uk2csPHS/u6dM4/EZ5RzZJMoc3sSL2Ftnd5D30a8380raWQ37PDsgqgo+XwyUsC8ecezUORYKUaiu8AlQFpK7NcZ2kqkqGNoNRUqkL5lv6/E 6rGGcxbPLAgjVmhsp7xtoJB/0/1nhlIxo/nNlOLvN8hVjXTEb7mxhtCkYIC4PnrI0k7Uco9RR/DSvYRlVtiOp0g8QbNMcYWGmMKQMmlbdATwpMwb6+o9/PKB 0f7OS+bm6jQC/JXUbtu66bq5e6dE+yd97Z+6+FMEUJMTDM6wT3RRAIFhkLAiFFivFkidzKEf81ZgWil9qupnniOLQrlviMaJxsrpGfXVuc/yafzDWGVoJxqP D3R2drlaxdCqAOIL1KqFuKS83fDDdoqFITo/xflSSwF5DDCAWnMaPTA/NzI97hMd3xRm78K1xATAN3zdgSDiuBna7qJ7k6d/keAn6jL4hVk/lTEMkAb4f45i 2MTqZy5jWM31PmqA90PGPUrXraELt3plhtT7xGq0dbSWVDd8k3RdHKG0EZyFASMtmNcJXDWCzo/KHUDfoovEGU1MmAHiSUcGg8zzov+mAvBSslhhkZbWLqGt AVIwa0VN8r0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hugues, Can you provide the output of the most recent v4l2-compliance? Use 'v4l2-compliance -s'. Also, just to confirm, with this v4 there are no /dev/mediaX or /dev/v4l-subdevX devices created anymore, right? This v4 looks good to me, I just want to have these final checks done. Regards, Hans On 7/31/19 2:56 PM, Hugues Fruchet wrote: > This patch serie allows to connect non-parallel camera sensor to > DCMI thanks to a bridge connected in between such as STMIPID02 [1]. > > Media controller support is introduced first, then support of > several sub-devices within pipeline with dynamic linking > between them. > In order to keep backward compatibility with applications > relying on V4L2 interface only, format set on video node > is propagated to all sub-devices connected to camera interface. > > [1] https://www.spinics.net/lists/devicetree/msg278002.html > > =========== > = history = > =========== > version 4: > - Also drop subdev nodes registry as suggested by Hans: > https://www.spinics.net/lists/arm-kernel/msg743375.html > > version 3: > - Drop media device registry to not expose media controller > interface to userspace as per Laurent' suggestion: > https://www.spinics.net/lists/linux-media/msg153417.html > - Prefer "source" instead of "sensor" and keep it in > dcmi_graph_entity struct, move asd as first member > of struct as per Sakari' suggestion: > https://www.spinics.net/lists/linux-media/msg153119.html > - Drop dcmi_graph_deinit() as per Sakari' suggestion: > https://www.spinics.net/lists/linux-media/msg153417.html > > version 2: > - Fix bus_info not consistent between media and V4L: > https://www.spinics.net/lists/arm-kernel/msg717676.html > - Propagation of format set on video node to the sub-devices > chain connected on camera interface > > version 1: > - Initial submission > > Hugues Fruchet (3): > media: stm32-dcmi: improve sensor subdev naming > media: stm32-dcmi: add media controller support > media: stm32-dcmi: add support of several sub-devices > > drivers/media/platform/Kconfig | 2 +- > drivers/media/platform/stm32/stm32-dcmi.c | 283 +++++++++++++++++++++++++----- > 2 files changed, 236 insertions(+), 49 deletions(-) >