Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp5459508ybh; Wed, 7 Aug 2019 06:23:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJRbUQWAWPw05UGBdH3CSIpk0tnLCnJN+M1+Ii1t8vH0TL/gn26fQAHwDrD2S4PDo7XRHY X-Received: by 2002:a17:90a:1d8:: with SMTP id 24mr8573991pjd.70.1565184205589; Wed, 07 Aug 2019 06:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565184205; cv=none; d=google.com; s=arc-20160816; b=xCD990YkALyujUU7lWS4D9HqTb02bcXQEoH17eG8ee1gtGVPbc2XUpqppeocPDQFxq UNRAeDeDCPG3iFHBD8muWttOGkdegfXHkED7qgbmktQvis2oFM5A8//D79C3YpHNfRrN ZKX+Y4oTXsuQSxhBOEonqctTfMX7BI1FXfPDssuiCiehEPHNhBk2GMaALsdiZmGbEBH9 jgxHC4tNQmkYWYkkwT52yUWu2feBzYRxuHSlfIdokLKfv9Bsbzl2Jrise/BHFpLM6QNE 44snyp1LQScWtR9DPeva+u7v2U8scxIj+kySMIOUMUCgCDEvItJ482OpjPuDITidVmMh 6fJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=qJa7xAH3LS4ZPpS866duyzjGdHO+TE3QxMrYdTaWzxM=; b=HP5lntyyzB+JIgtDmVU9PE8vvx8T3f7XabwLs73Y8S4Pgobq1fUzXgZnuMU3UH6t63 ejbtiW3fQZIBp08MF2qu19QwwOmIkCKQuZusS06jwF7C+mBfDY2Frw5drW7wRk2tLZn2 QTJLhjkpuwskgljSadVxDoZ8FwFusixd1YFustyQUnvHVG5TDJG+CPBzrv+FjociSGww 8IKKvvZXGNXZqlJWOHZu4C4ec263SFem2oCaLjDnytRhuf9cbnqX3w2cdnHzHcXa6QYs vUqLaPrGM32CS90VudpRpqPYsSLlv3Cinrz3+tRG8P32SImAeBpUMNM4i4o/LSpvLX6/ 1rXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si43524326plk.272.2019.08.07.06.23.08; Wed, 07 Aug 2019 06:23:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388324AbfHGNVr (ORCPT + 99 others); Wed, 7 Aug 2019 09:21:47 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52751 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388059AbfHGNVq (ORCPT ); Wed, 7 Aug 2019 09:21:46 -0400 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=localhost.localdomain) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1hvLsm-0002TB-34; Wed, 07 Aug 2019 15:21:36 +0200 Message-ID: <5707aee16681065a975ed42a06069674c3127edb.camel@pengutronix.de> Subject: Re: [Tee-dev] [PATCH v8 0/2] fTPM: firmware TPM running in TEE From: Rouven Czerwinski To: Jarkko Sakkinen , Sasha Levin Cc: linux-kernel@microsoft.com, linux-doc@vger.kernel.org, corbet@lwn.net, linux-kernel@vger.kernel.org, thiruan@microsoft.com, tee-dev@lists.linaro.org, jgg@ziepe.ca, ilias.apalodimas@linaro.org, rdunlap@infradead.org, linux-integrity@vger.kernel.org, peterhuewe@gmx.de, bryankel@microsoft.com Date: Wed, 07 Aug 2019 15:21:33 +0200 In-Reply-To: <20190711200858.xydm3wujikufxjcw@linux.intel.com> References: <20190705204746.27543-1-sashal@kernel.org> <20190711200858.xydm3wujikufxjcw@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: r.czerwinski@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I spent some time with the fTPM module and TA on a Nitrogen6X with the latest OP-TEE master. After stumbling through the "tee_supplicant no persistent storage" problem, my module now issues the following error message on module load: [ 34.633252] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff0006 [ 34.641035] tpm tpm0: tpm_try_transmit: send(): error -65530 [ 34.647008] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff0006 [ 34.654788] tpm tpm0: tpm_try_transmit: send(): error -65530 [ 34.660480] ftpm-tee ftpm: ftpm_tee_probe: tpm_chip_register failed with rc=-65530 [ 34.678087] ftpm-tee: probe of ftpm failed with error -65530 To me the TEE_ERROR_BAD_PARAMETERS indicates some ABI issue between the TA and the kernel module. Note that I built the TA from https://github.com/microsoft/MSRSec.git with commit 6bb57db632c424f87cbaf7ec6f9c89be7682b3c0. Maybe this is not the correct version, I had some problems building the module from the repository mentioned in the Patches Regards, Rouven Czerwinski -- Pengutronix e.K. | | Industrial Linux Solutions | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |