Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp5565557ybh; Wed, 7 Aug 2019 08:02:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvtwZrMWPxLXIpBnylRQXqFNkFdmvd7ynKY2x//FgLcwbeYS7zyX+YK0DY/IZtEJXZF6Xb X-Received: by 2002:a17:90a:2228:: with SMTP id c37mr366595pje.9.1565190169302; Wed, 07 Aug 2019 08:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565190169; cv=none; d=google.com; s=arc-20160816; b=Ier+X+XxqYkIlHLLXYtPqEvo+zlja+hbj/1+fepxduGa8n70bUqRzQfhpGPCw1w4hU HsOJvx7b/F+fMlTpHhG0lk4ETTOj/ox1hhlDifrP4UlGn4sFx2FbHpSp0vVI+25dRBRd LVDnsMecyZJ4LNE7XDPiWlxpvlaCd3EMC44NSa2jzPrSCWHlKYbGlKFP+vm6ciJ0GPKp mDHpBDB6Hba4/M2+5cJKVJzVkfudXwziIv9Fk3mw0H5HTAZzBb9GqtmmHa+VNpFfs0li LJkndJ3k8+1okVvgIZHBcsK08dGMPhj8MIC5agdhi2Dkr9I9f4LmQ8PFuxsO/cDgh6jk JtjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=KZ8uTQBbhCoVPVLq+C4BHS+Mf8ZC86MmMMrTG7ha+H0=; b=vBuIvYZmlaJ2OMpyr+slivK5bKt5imgwvtSOhONP8bGGkaZpYZ5rnSNC3j5FjQ74j5 tuQNB8YPkFE32mRHFA8oiCf9iy1+n+VBBdQY+LuyErE5NBzjgIowQ5DtIV2rjaCsFZfo EAnAkLhsZL5rMb0N/yzLl1I99T9q9VWgRw0NyS3MS3ZtKmeJ+xrR2LRCXB0tqJ+imkml rN4O7DI3Y0Rr+Vm4bIQsG382upQvYUVQSJT1MD6Bxkeul3pR5xiArUdbn7cO4Ey+VPAy mDEWDDaAT4JlDmFRX2dPqJQeiMyBTdomlb2h0ZD+Md8aFpFlIB+uW9b/M60H3ZlqVztT XuJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jp0UtNZC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si49439511plt.30.2019.08.07.08.02.32; Wed, 07 Aug 2019 08:02:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jp0UtNZC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388175AbfHGPAO (ORCPT + 99 others); Wed, 7 Aug 2019 11:00:14 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46729 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387915AbfHGPAN (ORCPT ); Wed, 7 Aug 2019 11:00:13 -0400 Received: by mail-pl1-f196.google.com with SMTP id c2so41198700plz.13 for ; Wed, 07 Aug 2019 08:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=KZ8uTQBbhCoVPVLq+C4BHS+Mf8ZC86MmMMrTG7ha+H0=; b=Jp0UtNZCC8cbLtwVC11RHbJ5sVa6xcn/gHKlJHfNoAjGid9R1Ro/fP956hygnVjnlx UXeRVeP6z12LPFFvwUt4MGsHKitKyDjNpezOtPUTkpdN8zJWkAx3Ky3KuJczrqCmKJPD BlsXtDa2l9ldljcENRwWPj+3XjCA6TNE+VAno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=KZ8uTQBbhCoVPVLq+C4BHS+Mf8ZC86MmMMrTG7ha+H0=; b=M0srrtcspWTJaNGa+UR4PYvGMZcqIlw3NxNwA7ucHE2AYjxxe9lzuNF7smbc/ZyQJL y/iKaxILXfl+nYA0xjbIxLZfZiltsGmZbvn1TjzMRC3aV1EGqLneix/6QCJb8Q+WQ0Jd ba+o6fAINIYSn8r05KdfrV3FTwYnbVJiNh3Xz6+2yPn4q9j3FdiMWvxaeYhCrGGdVcWa dyYfDcDPG5auota/IilVs14DiFmKgO7wdMoNIAllHIvA/jH4HlMfRJseSnM4sC6Y2CGe Sc47b0t+dICe2UUwCjPcIjPzwS8hafXKb20oEkRedpYtxuI5Oms+vKp+21sT26RBTFwl NRpw== X-Gm-Message-State: APjAAAU+VFhOIEolJmQHuEljrqaYTYcUzVMLkNVInIfnXF3VcKB2Zpwa N2PmaCsUjIFpMTY9cK8ATi9m2g== X-Received: by 2002:a63:dc4f:: with SMTP id f15mr8183383pgj.227.1565190012942; Wed, 07 Aug 2019 08:00:12 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id 143sm141606468pgc.6.2019.08.07.08.00.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 07 Aug 2019 08:00:12 -0700 (PDT) Message-ID: <5d4ae77c.1c69fb81.8078a.b6ba@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190807014846.143949-2-trong@android.com> References: <20190807014846.143949-1-trong@android.com> <20190807014846.143949-2-trong@android.com> Subject: Re: [PATCH v8 1/3] PM / wakeup: Drop wakeup_source_init(), wakeup_source_prepare() From: Stephen Boyd Cc: rafael@kernel.org, hridya@google.com, sspatil@google.com, kaleshsingh@google.com, ravisadineni@chromium.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kernel-team@android.com, Tri Vo To: Tri Vo , gregkh@linuxfoundation.org, rjw@rjwysocki.net, viresh.kumar@linaro.org User-Agent: alot/0.8.1 Date: Wed, 07 Aug 2019 08:00:11 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Tri Vo (2019-08-06 18:48:44) > wakeup_source_init() has no users. Remove it. >=20 > As a result, wakeup_source_prepare() is only called from > wakeup_source_create(). Merge wakeup_source_prepare() into > wakeup_source_create() and remove it. >=20 > Change wakeup_source_create() behavior so that assigning NULL to wakeup > source's name throws an error. >=20 > Signed-off-by: Tri Vo > --- Reviewed-by: Stephen Boyd