Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp5880178ybh; Wed, 7 Aug 2019 13:04:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbTK21HBRdVADWBEy7Bg4RXG6JHlUS/zQj0O2soGd98Y+WgMgf60T7M8UHteyeUXkSzz6B X-Received: by 2002:a63:2b84:: with SMTP id r126mr9514070pgr.308.1565208241850; Wed, 07 Aug 2019 13:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565208241; cv=none; d=google.com; s=arc-20160816; b=aa7ohRdHosXGBzWSzmIfhiwlHRJBR7CE/7nfEKEgwA+kwDCN2SnKjdvp1HNEDrVkz3 XEeH65ONz+KviHNCW3cZY0NP+/MBeC/Gm7AOIaJ8EyTzQ0keJWo21+KiCUp+Db9nD4CL Dyas5hC+qrH5GV5CJEDVmZliJqIoHGxt1CBEHBHUhQSFB9UIjMjpaIUuYgnZLphA6MBi GZR7KuZl+pjQqDkjDwrqVOk+m5KpBeb7jCga6d9Q/q0IqTpC+1N58JGle53y+DgzFV0V l8OIz3Z7ZNm4xTgCXTlkiscGqlxtWJH7EVA8RPq0hCIl49BbSlkSOGvM6nKM81rnHofp HZAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=R7q4DOl8O4PE+6BWh0cAXRcqIQUKkm71xqz/IGPsB+c=; b=EKNp6U9mjl5i0E0k12AMuTzfqQ1YH0IPldsAInkicCUYWcEuXgrh9tdOxJ5v6bdD1a 08CwaGFV/cQP5TIs9ag5uv9C+V0rYCIQ/wlVtJTXbEc6S0LvnhYFxe8NrVpOs/W1sOv8 8j/H++Plb1Q5YIlJr5MP/tDG4rLVnRIQmUsVlxuQqypcIWsNKDo4n2qxIrh099pYmKTV wOEGgnoNwB6JlI7ZK8FWeMKBzOfge/jN/+PqnmFke+oEMas7Qb5II0t2OJBUg2H5LusS S0/2Ym7dy1owHTNMRRdimgzrFjcBpgONNQ/NQ27K1oia2vPxGxIxBQjLcmFnHLB5cUu/ ld/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zQWA7F1K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id br15si59345pjb.43.2019.08.07.13.03.35; Wed, 07 Aug 2019 13:04:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zQWA7F1K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388554AbfHGUBY (ORCPT + 99 others); Wed, 7 Aug 2019 16:01:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:46056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729804AbfHGUBY (ORCPT ); Wed, 7 Aug 2019 16:01:24 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D7B42229C; Wed, 7 Aug 2019 20:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565208083; bh=4Y+9zhlp+p8rLuzDnvz16xcsN6RE4cU24OrOaFTWccE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zQWA7F1KoIQRCIl1yVyS0BiJUwsrwYEryJKxMHNxcX6ONB8eZ93zxVmeDQ44zmmr7 94PMczCgAY0emIRaZfVAe7SJ/fxtD+5a/tCkNgG8bpb7LPhysLSpabBlToJlvBBdXz 27kDL9DLZKISnabXM7rW3N8cStMFHWeqYCj5Xb7E= Date: Wed, 7 Aug 2019 13:01:22 -0700 From: Andrew Morton To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Alexey Dobriyan , Borislav Petkov , Brendan Gregg , Catalin Marinas , Christian Hansen , dancol@google.com, fmayer@google.com, "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Kees Cook , kernel-team@android.com, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Mike Rapoport , minchan@kernel.org, namhyung@google.com, paulmck@linux.ibm.com, Robin Murphy , Roman Gushchin , Stephen Rothwell , surenb@google.com, Thomas Gleixner , tkjos@google.com, Vladimir Davydov , Vlastimil Babka , Will Deacon , Brendan Gregg Subject: Re: [PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing Message-Id: <20190807130122.f148548c05ec07e7b716457e@linux-foundation.org> In-Reply-To: <20190807100013.GC169551@google.com> References: <20190805170451.26009-1-joel@joelfernandes.org> <20190806151921.edec128271caccb5214fc1bd@linux-foundation.org> <20190807100013.GC169551@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Aug 2019 06:00:13 -0400 Joel Fernandes wrote: > > > 8 files changed, 376 insertions(+), 45 deletions(-) > > > > Quite a lot of new code unconditionally added to major architectures. > > Are we confident that everyone will want this feature? > > I did not follow, could you clarify more? All of this diff stat is not to > architecture code: My point is that the patchset adds a lot of new code with no way in which users can opt out. Almost everyone gets a fatter kernel - how many of those users will actually benefit from it? If "not many" then shouldn't we be making it Kconfigurable? Are there userspace tools which present this info to users or which provide monitoring of some form? Do major distros ship those tools? Do people use them? etcetera.