Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6177004ybh; Wed, 7 Aug 2019 18:53:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxSei4BX8FqJIhUTJmuAvhA6ac9nwrWZAnGgjBaawAK/g1zeVNfXidK/212RsMYVYXwn3o X-Received: by 2002:a63:1341:: with SMTP id 1mr10627912pgt.48.1565229211295; Wed, 07 Aug 2019 18:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565229211; cv=none; d=google.com; s=arc-20160816; b=D5O1IirH/wDvsJhWsc+lCzMJX6jEkeVmksaFk6RmmeDL1Fbpu/kw0g0JfNcMmOlz3o J0/TqcsgGODLGaQvDr/K7pTfTvVNfPF2m8LjNMB5bX87pxB4EUrN1aS8n4vwl0Ne0mPH JCUzcqj5t9sqYTsBZ3XliQ/eHRKSzoc60Rl8L9pF20/J+HChM0WM8bwglAW9oYuTYKR7 t84eSs1QsJIa0XOs6pXqZm5oFCOkGdncLH6euRw8ML7BfqLNNehGpCm6DNPqoTWwFEvT honTNLJQ8scZ6fvVn5mS0vxjDx/74rkbc7Zl/sFjx+EUKZI2yZSrgC625FVTBZG8GO1F P0lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=fqar6kzjg03/VcvUI5mP5RbL8vn7I1Tl9jgrXQ+77Ik=; b=AlqGHnOGtstoFuF15KdCpPoG3ppNrqbSL4nAFH0KA09KWkV9U0Ujpfhd/1b0Kf7Q2B aA75qB4Els4JHfQ1Xd/P+qvBFieOiOqGMoj80NxqjG+aL21CsOagdTSYCTp/ISOeCA9/ 9H0R0tIlVP9+ee4+ZlxjfKRvIfQwVOdn2kKWz7wlIWUfVM5NvfBeXV+MQbsPB00Te5Lt RDWzJW63XIctD83FARcmc09j8PLvh9ryPrUFZZhU+rYkzC7o37vrB/i4tBjyaQ2ynMxw Rqokvvdc7c+4aAmhAIP5jqpPpm+ILtc8ZYAQuTBoC/iArtaXT/3lsWentilTWUPqNO4A KxoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Ucm0qWTX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j27si41070721pgj.571.2019.08.07.18.53.15; Wed, 07 Aug 2019 18:53:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Ucm0qWTX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389634AbfHHBvZ (ORCPT + 99 others); Wed, 7 Aug 2019 21:51:25 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54120 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730038AbfHHBvZ (ORCPT ); Wed, 7 Aug 2019 21:51:25 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x781mxSG138309; Thu, 8 Aug 2019 01:51:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=fqar6kzjg03/VcvUI5mP5RbL8vn7I1Tl9jgrXQ+77Ik=; b=Ucm0qWTXP3Hk+ghOPnUvolTPNLw7JB1Tr+MCp0iOUlNK3BWq+r/Rb+PcpnJ+ha12yqo9 sDofcaYtd8guu+duCsNrVMUkAtxb6MZBEjUEaD1ry/8jl1M8x1Dd7Zo6A7kLpAwoNJWn N/mCKHWwXEXouYBEOGG2o/bCMGTtsxPyYiIvAet2H/mwu9LcrVXP4OuFYLl3vLuc69si GIvl75ZjSr0T0KWIj220JT1CtV5J143WlFDgMGKmkUeDUMf0TeLphJNP4+aU/j33YkbK DqbDRpytYm7Gxq9vn1DxNHHF0Lv0Cs28Ct+dJaoGEixxxvdFr+BoF1mXdjRNLTuc+0ol iQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2u527pygxu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2019 01:51:14 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x781lwuX143092; Thu, 8 Aug 2019 01:51:13 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2u7668a0vv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2019 01:51:13 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x781pAv9011890; Thu, 8 Aug 2019 01:51:11 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Aug 2019 18:51:09 -0700 To: Anil Varughese Cc: , , , , , , , , , , , , Subject: Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190802112112.18714-1-aniljoy@cadence.com> Date: Wed, 07 Aug 2019 21:51:06 -0400 In-Reply-To: <20190802112112.18714-1-aniljoy@cadence.com> (Anil Varughese's message of "Fri, 2 Aug 2019 12:21:12 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9342 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908080016 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9342 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908080016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anil, > Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of > .setup_clock() because if UFSHCD resets the controller ip because > of phy or device related errors then CDNS_UFS_REG_HCLKDIV is > reset to default value and .setup_clock() is not called later > in the sequence whereas .hce_enable_notify will be called everytime > controller is reenabled. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering