Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 8 Aug 2019 11:52:45 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chuhong Yuan <hslester96@gmail.com>
Subject: Re: linux-next: build failure after merge of the crypto tree
Message-ID: <20190808115245.0c88c300@canb.auug.org.au>
In-Reply-To: <20190805145736.2d39f95b@canb.auug.org.au>
References: <20190805145736.2d39f95b@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Cdn2bCWDZ7kVZqfm9YvqfR+";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/Cdn2bCWDZ7kVZqfm9YvqfR+
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> w=
rote:
>
> Hi all,
>=20
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>=20
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first u=
se in this function); did you mean 'cdev'?
>   err =3D devm_hwrng_register(&pdev->dev, &np->hwrng);
>                              ^~~~
>                              cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier =
is reported only once for each function it appears in
>=20
> Caused by commit
>=20
>   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
>=20
> I applied the following patch for today:
>=20
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
>=20
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration AP=
I")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/char/hw_random/n2-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-=
drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
>  	np->hwrng.data_read =3D n2rng_data_read;
>  	np->hwrng.priv =3D (unsigned long) np;
> =20
> -	err =3D devm_hwrng_register(&pdev->dev, &np->hwrng);
> +	err =3D devm_hwrng_register(&op->dev, &np->hwrng);
>  	if (err)
>  		goto out_hvapi_unregister;
> =20
> --=20
> 2.20.1

I am still applying that patch ...

--=20
Cheers,
Stephen Rothwell

--Sig_/Cdn2bCWDZ7kVZqfm9YvqfR+
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1LgG0ACgkQAVBC80lX
0Gy5Vwf9FbyB0CanhhAKbljUp3638ElADCsp3vzNhhA19zlow8SLSEUDu6DCZhxx
SSKovam2VtyMS+xe0fYCZDdHJySUySmwtJHQYahnOJ4qC0W/kP2R3/FTPyRJQLvV
ux586Y8HfIXT5LMkjYwKIDc4/zz00f0pWTJqvf0bibvNEcqFmX8uuhFfFsQfyVSF
kQ1d62oMq1K1IOco7h3VdbXtbFMxJ14Isx4/6J7QZuADwBfJ99M8LW9f93cVRqmN
TXtTbZxAAFXq6txuOhHrWQyiupVdw4J58mvXMsXMaE21aPW4s6ybdldRoevBERP5
NUrAcHBw9U6TgMsF7Mlw9z8fYSXZkQ==
=seSx
-----END PGP SIGNATURE-----

--Sig_/Cdn2bCWDZ7kVZqfm9YvqfR+--