Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 08 Aug 2019 08:20:28 +0200
Message-ID: <s5hwofokwk3.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Wenwen Wang <wenwen@cs.uga.edu>
Cc:     "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        Jaroslav Kysela <perex@perex.cz>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: fix a memory leak bug
In-Reply-To: <1565241321-2418-1-git-send-email-wenwen@cs.uga.edu>
References: <1565241321-2418-1-git-send-email-wenwen@cs.uga.edu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 08 Aug 2019 07:15:21 +0200,
Wenwen Wang wrote:
> 
> In sound_insert_unit(), the controlling structure 's' is allocated through
> kmalloc(). Then it is added to the sound driver list by invoking
> __sound_insert_unit(). Later on, if __register_chrdev() fails, 's' is
> removed from the list through __sound_remove_unit(). If 'index' is not less
> than 0, -EBUSY is returned to indicate the error. However, 's' is not
> deallocated on this execution path, leading to a memory leak bug.
> 
> To fix the above issue, free 's' before -EBUSY is returned.
> 
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>

Oh, it's a really old bug.  Applied now.

Thanks!


Takashi