Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6516635ybh; Thu, 8 Aug 2019 01:19:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/P+5hcdrrH5TX+wNFJjDrpbpopNHdNrhkMp8Piztp2PvEAIMoFlkZeaag0ZuBDE8oCgWC X-Received: by 2002:a63:dd16:: with SMTP id t22mr11725410pgg.140.1565252366814; Thu, 08 Aug 2019 01:19:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565252366; cv=none; d=google.com; s=arc-20160816; b=MUa/sIe+wQj7vfu7ZEJzcCjm5HYO4yKIngQ/cYEIkbTjVuxMCurO6dt1KbfyaSNnlQ 228ewU9Bp/AsBarT8kq4+vW9nPcINOdy+hwRCrPkUtrjOBwOyrOKcMVoDlcsPkN/f75x GhWSSuIvTbz6Dk4/YKQFasz3wqGxYk8nIZHl1346Z7CiWKkszUICTy52PI1jZeGYPs2o nWySqDDm0SMtwLnVJFyUL9AmdDgF+2x+QrTykliLlkZ55lJM0inRHz3ZcHT6xdoySjMz 7N1XUe0TrLj6lPtjkZ7jsyIkx0al1v+ir7Ts+SILuH2sj91ysMIRvjZnREMZX5WvifNN 9i8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=dNM5N57Ioc8DGeTZqQ0rAIXdhWsFh5H0j1dVFwmVmb4=; b=JDWI2Bs9GJpDAIeOsMJtS2LW/pnPWbBxsLsQz2D4VDDVzlDY9HQGEfTFXvmacwQRb3 xyYFnr1bi1FJbZ/I/XAZsDL082oOxPV8pDKnIhsa1gsz0vgGuqTfgH9tAKj8LXy0VQ+1 /Ru2pVNYV/5TfF+8Iq2NHhS1lc6i1twgopjSswWaUfvAQthNrhEkPgeuCej9bmBfT91F c0ZGPVV7Ugl7RvpeJE8sU+Rwsnb857R1i8oCHBAF4p25kwGN7coneFm8/tcIsobJawKk PdUzgaGhphCX8k6DB8L9Z4KKTzCGCt0tRwTPkV1hVdBoFEt3rWNFdiKJrk/NByeIDVJQ GE7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=gtTvn2In; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v45si50288590pgn.10.2019.08.08.01.19.11; Thu, 08 Aug 2019 01:19:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=gtTvn2In; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731997AbfHHIRN (ORCPT + 99 others); Thu, 8 Aug 2019 04:17:13 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36752 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731642AbfHHIRM (ORCPT ); Thu, 8 Aug 2019 04:17:12 -0400 Received: by mail-ot1-f68.google.com with SMTP id r6so115227363oti.3 for ; Thu, 08 Aug 2019 01:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dNM5N57Ioc8DGeTZqQ0rAIXdhWsFh5H0j1dVFwmVmb4=; b=gtTvn2IndIxQCjjyBbjHq+P0txQocLhuW0xeMXqj5eVcDPoq6BuVqI7IpQwk2ignJU 8DyRLC//uN/6s4e1rWXVDWevrneTBo4+Q9LtC2vL7AMkKhAOJx/zCw92RkkPUkwDWzSg Z6NT0FKxGa9xWPFOpGlnTaPTBu2ViA8/jlzJ2yIIPPoicWJH3Z0vbjMwPgB7EacgrSfH bY5qy+QwCAe8+Cb4SG0+Ennjuw3jVUeJKC/t8B+QMcMwMz8hVDhbiATUYO+l5pkzllhX iA98x/+0bobd6W0fdIaTCHrNOytdTCvT5jvTWdGy1E0GmN3OM+5b5NAV4IwZjrFZhUek SK6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dNM5N57Ioc8DGeTZqQ0rAIXdhWsFh5H0j1dVFwmVmb4=; b=dX6AgkaQxojjJGvsYDOPAI1Hct5A7f5mlenK9tE9N7ljR6MrLv5iCPoPOJiOpPcrr7 Jc077Cf+GckBnCEBLDODgOYiggdF5rxHuFBhY0wYqh5ATHascLjPGfOFdIrw7T4PXrmK Sv/WcE7tuc93GuT77/6kBMiVwDwRPXVqOncmy5yzlU+NrVhuu2qh3/WFsgUCB9OGwXeN F6cLzUhH2psqsmVbIHbS7ZWPSrDnH3OngXxhbg9xgSUafxdo7Yeqdt0ScoKvXE3XAcZY jTWCUEs4R17Aa06ztgKE2HYjS4OPQLUXtRbnK8i22kQgUSDA1atZDYZzfAQ/cNvh6aIg +Emw== X-Gm-Message-State: APjAAAWE9RHrRh7E1yGz3TvSyNNKNjW2naxlJzb3eqt9p3d0kcZrZKvv ZzPV5PT1KKK0wbgeR/pv/6P9EBLC6ZJ7nW1f/DH7zw== X-Received: by 2002:a6b:f80b:: with SMTP id o11mr13530588ioh.40.1565252231701; Thu, 08 Aug 2019 01:17:11 -0700 (PDT) MIME-Version: 1.0 References: <20190724082508.27617-1-brgl@bgdev.pl> In-Reply-To: <20190724082508.27617-1-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Thu, 8 Aug 2019 10:17:00 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] backlight: gpio: simplify the driver To: Yoshinori Sato , Rich Felker Cc: linux-sh@vger.kernel.org, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Shevchenko , Daniel Thompson , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 24 lip 2019 o 10:25 Bartosz Golaszewski napisa=C5= =82(a): > > From: Bartosz Golaszewski > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do > that. > > The first patch adds all necessary data structures to ecovec24. Patch > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > 3-4/7 remove unused platform data fields. Last three patches contain > additional improvements for the GPIO backlight driver while we're already > modifying it. > > I don't have access to this HW but hopefully this works. Only compile > tested. > > [1] https://lkml.org/lkml/2019/6/25/900 > > v1 -> v2: > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > - added additional two patches with minor improvements > > v2 -> v3: > - in patch 7/7: used initializers to set values for pdata and dev local v= ars > > Bartosz Golaszewski (7): > sh: ecovec24: add additional properties to the backlight device > backlight: gpio: simplify the platform data handling > sh: ecovec24: don't set unused fields in platform data > backlight: gpio: remove unused fields from platform data > backlight: gpio: remove dev from struct gpio_backlight > backlight: gpio: remove def_value from struct gpio_backlight > backlight: gpio: use a helper variable for &pdev->dev > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > include/linux/platform_data/gpio_backlight.h | 3 - > 3 files changed, 44 insertions(+), 74 deletions(-) > > -- > 2.21.0 > Hi Rich, Yoshinori, can you ack the sh patches in this series? Bart