Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6532938ybh; Thu, 8 Aug 2019 01:37:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqycsDCDDmVFVYxmva6k2AXhq2BNyzQ2UZiBCmWWjKH8+dQiq8f+wmsdtgJlBbKT9HUAAtVf X-Received: by 2002:aa7:9514:: with SMTP id b20mr14522601pfp.223.1565253437079; Thu, 08 Aug 2019 01:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565253437; cv=none; d=google.com; s=arc-20160816; b=WkRx43+EKFOROSaGBy1fl0+v96PY9m1YR1C3CvK34Xy2563+kxT/W08DfP+G7sm6iv pmYH36nzqy0sOtAVkfjbO6/QLvI9l56m5oX2LFlraJEYh/7Y7On8vqXVDicsCqKmgFce JL9rTJRL5u1b4I8qwI7q3uKNwZ5/gD8iCPfw8irWhg+XQaWFzLySXCcH+1ybzQPD4kUX g/eVAgQV32q8YcbCIqhN3rROmh+FPP5xvtyDGBgoWJTMjU2Ib4IkgfZL2SFxpZ6jbusQ JH0j/aNVN0ICnE+f4lVQkeQaRQzipZM/7eSdyypxnCf4MhFRnRxKFJzN1pAbkoJeY9Fw hQSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zcqBH5ar3OzP4hnrtujwg0ysdgeeKQb3L3vg4Dg7AHU=; b=YIqfRr1eX7LzBg7v1B3JEZaS6XoPti+Ix3xFQ8r4kacPcprt1z9g7ClSnk2RbbMYrm UxJdXJlf9TiLILDSjl78xuIte47gkYa//oAPPA2GQOPpUV3fqPZwfy1s/4z5vbe27hPd Z3Q8CtdYx0t9LXxjC10I4mWLZ6qDdXVU/nZ9PrTXdW81s083MHlvGv+cZOT6iguD/jBL Crb4V10/pcRaPjrdc23gIZPagWkWfLfUag14ColKqhhKk2cx/Gb24xSRLzw6i6EaTTQo ALg4UykCx557w1Dm4pkJk1XBCCwpurfD1KqJnnjn9Zpzc8PhBxv7dUhNIxOF9/EGBmLs Qquw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p125si51177054pfp.35.2019.08.08.01.37.01; Thu, 08 Aug 2019 01:37:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731479AbfHHHtC (ORCPT + 99 others); Thu, 8 Aug 2019 03:49:02 -0400 Received: from verein.lst.de ([213.95.11.211]:44133 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfHHHtC (ORCPT ); Thu, 8 Aug 2019 03:49:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B117968B02; Thu, 8 Aug 2019 09:48:58 +0200 (CEST) Date: Thu, 8 Aug 2019 09:48:58 +0200 From: Christoph Hellwig To: Lucas Stach Cc: Christoph Hellwig , "Lendacky, Thomas" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Thiago Jung Bauermann , Halil Pasic Subject: Re: Regression due to d98849aff879 (dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code) Message-ID: <20190808074858.GA30308@lst.de> References: <1565082809.2323.24.camel@pengutronix.de> <20190806113318.GA20215@lst.de> <41cc93b1-62b5-7fb6-060d-01982e68503b@amd.com> <20190806140408.GA22902@lst.de> <1565100418.2323.32.camel@pengutronix.de> <20190806154403.GA25050@lst.de> <1565191457.2323.41.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565191457.2323.41.camel@pengutronix.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 05:24:17PM +0200, Lucas Stach wrote: > I would suggest to place this line above the comment, as the comment > only really applies to the return value. Other than this nitpick, this > matches my understanding of the required changes, so: > > Reviewed-by: Lucas Stach Thanks, I've applied it with that fixed up.