Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 08 Aug 2019 11:12:49 +0200
Message-ID: <s5hftmcja0e.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     " Takashi Sakamoto " <o-takashi@sakamocchi.jp>
Cc:     "Wenwen Wang" <wenwen@cs.uga.edu>,
        "moderated list:FIREWIRE AUDIO DRIVERS" <alsa-devel@alsa-project.org>,
        "Clemens Ladisch" <clemens@ladisch.de>,
        "Takashi Iwai" <tiwai@suse.com>,
        "open list" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ALSA: firewire: fix a memory leak bug
In-Reply-To: <ce36089b-7061-4cd1-8262-eb3393c753af@www.fastmail.com>
References: <1565243458-2771-1-git-send-email-wenwen@cs.uga.edu>
        <ce36089b-7061-4cd1-8262-eb3393c753af@www.fastmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 08 Aug 2019 11:04:03 +0200,
 Takashi Sakamoto  wrote:
> 
> Hi,
> 
> On Thu, Aug 8, 2019, at 14:53, Wenwen Wang wrote:
> > In iso_packets_buffer_init(), 'b->packets' is allocated through
> > kmalloc_array(). Then, the aligned packet size is checked. If it is
> > larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
> > However, the allocated 'b->packets' is not deallocated on this path,
> > leading to a memory leak.
> > 
> > To fix the above issue, free 'b->packets' before returning the error code.
> > 
> > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
> > ---
> >  sound/firewire/packets-buffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> 
> And this bug exists till its first commit for v2.6.39.
> 
> Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
> Cc: <stable@vger.kernel.org> # v2.6.39+

Applied, thanks.


Takashi