Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6718520ybh; Thu, 8 Aug 2019 04:38:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzyTbBfon41LtgzTXT/KoxfXFntu1faNzBOTiNRLPuoD1AEb6Bm6V1dDtDbxGUCe/huA5h X-Received: by 2002:a17:90a:1a0d:: with SMTP id 13mr3466161pjk.99.1565264325282; Thu, 08 Aug 2019 04:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565264325; cv=none; d=google.com; s=arc-20160816; b=WKOEkp9NOysZrwXbOE0cMwTn1N5RKsKOeqGzpwHU/AmlN8b4dLTEpHA3wxyRqSjWvc qlykjfHIIF4rZmD03yGMeD4jomeWQ9iAasHzzFHBaFrhzt/Q7R/cBKZKckGz5gogR2X9 id/z1SAZH8inBfiULDEutltUJNr+auG2mXR9BJiZB0uCG6Gc3Lr3y07sqUd2o4V4nlio VCi6eyQwoSpK2OtURwZbbcDyxo3bNsqT5PUXgFk/CuBr3osrfTUIb6fV+SoKdN6Kwxhr N2OuQi6dhMmlUYvCHTsn1roDuQ521Iy1YfEc1Yjt3kquIIm/Q7YDv0RF/tX5nqM/xbw1 +JlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jbfCyv+PPMX0MNqqc+CRmZGZ8B8TIYMXW8wUct7JViw=; b=ppFSAzU0YiptLGplWFlp7TJ+AmNHqqeLUe/qMnzuWftn/Z7cLcOiiGmsOALNhVKDGL XoMs+2U/P3+wTN4pyaw8twuSUCGayxUGGSZ4w55uV9qtjo75lV5uqmII7xVrnm1RL8Z4 xySAXyIqPlRO0TGzTFVrmDSoQ7rVGO+fkqIW0n/phT+wqR6/JGxeiZohY5s6ZvbYyfXN 9bx6RJ3al3cDw9WlXQXdYAmH4SCsjQFyq/r12SbmE1mMAmjFi+IqgDwxMU1HbJVvJTzX Doy0WwwmpILI52f58d4w1wSpfmS2EX+pUqkB4tj9W5eJmCLeAnwMADwMWc+5Yuh6Dws/ e3ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si14935532pgi.304.2019.08.08.04.38.30; Thu, 08 Aug 2019 04:38:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729449AbfHHLgU (ORCPT + 99 others); Thu, 8 Aug 2019 07:36:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbfHHLgT (ORCPT ); Thu, 8 Aug 2019 07:36:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 092BD309BDAA; Thu, 8 Aug 2019 11:36:19 +0000 (UTC) Received: from dhcp201-121.englab.pnq.redhat.com (unknown [10.65.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8631C61B61; Thu, 8 Aug 2019 11:36:16 +0000 (UTC) From: Pankaj Gupta To: amit@kernel.org, mst@redhat.com Cc: arnd@arndb.de, gregkh@linuxfoundation.org, virtualization@lists.linux-foundation.org, jasowang@redhat.com, linux-kernel@vger.kernel.org, pagupta@redhat.com Subject: [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf Date: Thu, 8 Aug 2019 17:06:06 +0530 Message-Id: <20190808113606.19504-3-pagupta@redhat.com> In-Reply-To: <20190808113606.19504-1-pagupta@redhat.com> References: <20190808113606.19504-1-pagupta@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 08 Aug 2019 11:36:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch makes packed ring code compatible with split ring in function 'virtqueue_detach_unused_buf_*'. Signed-off-by: Pankaj Gupta --- drivers/virtio/virtio_ring.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index c8be1c4f5b55..1b98a6777b7e 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1534,6 +1534,11 @@ static void *virtqueue_detach_unused_buf_packed(struct virtqueue *_vq) for (i = 0; i < vq->packed.vring.num; i++) { if (!vq->packed.desc_state[i].data) continue; + vq->packed.next_avail_idx--; + if (vq->packed.next_avail_idx < 0) { + vq->packed.next_avail_idx = vq->packed.vring.num - 1; + vq->packed.avail_wrap_counter ^= 1; + } /* detach_buf clears data, so grab it now. */ buf = vq->packed.desc_state[i].data; detach_buf_packed(vq, i, NULL); -- 2.21.0