Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 8 Aug 2019 12:44:01 +0100
From:   Qais Yousef <qais.yousef@arm.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Ingo Molnar <mingo@redhat.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: schedutil: fix equation in comment
Message-ID: <20190808114401.ziyxnm5yffjupnpm@e107158-lin.cambridge.arm.com>
References: <20190802104628.8410-1-qais.yousef@arm.com>
 <20190805130620.GL2349@hirez.programming.kicks-ass.net>
 <13854122.nn4VJ8hDQq@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <13854122.nn4VJ8hDQq@kreacher>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/07/19 11:42, Rafael J. Wysocki wrote:
> On Monday, August 5, 2019 3:06:20 PM CEST Peter Zijlstra wrote:
> > On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote:
> > > scale_irq_capacity() call in schedutil_cpu_util() does
> > > 
> > > 	util *= (max - irq)
> > > 	util /= max
> > > 
> > > But the comment says
> > > 
> > > 	util *= (1 - irq)
> > > 	util /= max
> > > 
> > > Fix the comment to match what the scaling function does.
> > > 
> > > Signed-off-by: Qais Yousef <qais.yousef@arm.com>
> > 
> > Thanks!
> > 
> 
> I've applied this, so please let me know if it has gone into -tip too and I'll drop it then.

FYI I've just got an email from tip-bot that it was committed there.

Thanks!

--
Qais Yousef