Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6789330ybh; Thu, 8 Aug 2019 05:46:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuW/okb5uNnLN7J3N7VyojfFEBFdBqaJf62Z1FlyYcW9jZqdbXvMSZj7iefddCgvKth3XD X-Received: by 2002:a17:902:a60d:: with SMTP id u13mr13769856plq.144.1565268371460; Thu, 08 Aug 2019 05:46:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565268371; cv=none; d=google.com; s=arc-20160816; b=MbDgJmhmlgVDhMrEDqLBJ2JZPv+hWlUh+eAXRLhd5QIC/SSoR3/0CrZRJNvN0Ds9W6 4tN8f+hvRqGr7rxRnNFJ8MPll4+pfohmgVuFFj+0HOwq1wgnExR0L4kyQHPMhsWfGewY SZmPA3Ju0Va5HifRCiicKM+YrVeSxt2uNu++7DKFq4ZqMo0bsoB4y+mh0+ns9tHrBy+n WnDBqbEwOHkrMYylS5xqkSi+YkRK6WRUOEET9SqUHa3MSXIlIVN9SS1eC2bDm356616u cPcB8uPwSp6DKtViX4+O6ps0tnkmhxZk6ho2XiMjxBvvMlqLves7A1GICpLKdsH7VKWO BPSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lCsofZGv+cxb/oUf1c4muQ0GNQflHlLh+n32fEyltgY=; b=qrT52FO5LIXAcIST+AXJ5LYdb3LndU8Z5xmXNhRJaZNOX9gQIxTp0biZGp80L35J04 rAVSYppERCCSbV8tVn6Bhcsjtt7LIWkkfc5PlUXvfrywecHVGCk2mL8xrW0/RYo1U0Ge UkablXTW6L1LyOsk33cXCsGowQKY2jPO1h7mD8cybkr8SxqspMojxa7u0IeSpyG3YdqL hTNBOkIdQhMBcxHLvW04hIksPhCVa94dI3OWB4Q0IQ7AthpIrWgy8S6abQwq3XcwDh8A 5GXVzVwg7FaPNRXXeNo6yz5KQMF3l1ap2vN+k1824Vq2ooAe8gjX0skTTo74SmI36zwB M0MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=rq4cT89p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v27si53161065pgn.14.2019.08.08.05.45.56; Thu, 08 Aug 2019 05:46:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=rq4cT89p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732377AbfHHMoy (ORCPT + 99 others); Thu, 8 Aug 2019 08:44:54 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:33634 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728964AbfHHMox (ORCPT ); Thu, 8 Aug 2019 08:44:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lCsofZGv+cxb/oUf1c4muQ0GNQflHlLh+n32fEyltgY=; b=rq4cT89puSmiOH6w551MDjl6P WFKsDiYQyjd16N+pdyGRdfd/4TbFM9y1ujcg5J0XPaEvbtEUC0HQUAQcsd32ZZasiVEHnZ/bQ1QAr /MeWf9p6T1hy+UyDZVVngOwOaODEFK6Lq4bcxCPDxX6ZZf35zRZ9DOHsQYHVJbLezWdoE=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hvhmY-0002rE-S3; Thu, 08 Aug 2019 12:44:38 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 8BCD22742BDD; Thu, 8 Aug 2019 13:44:37 +0100 (BST) Date: Thu, 8 Aug 2019 13:44:37 +0100 From: Mark Brown To: Stefan Agner Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Agner Subject: Re: [PATCH] ASoC: soc-core: remove error due to probe deferral Message-ID: <20190808124437.GD3795@sirena.co.uk> References: <20190808123655.31520-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/unnNtmY43mpUSKx" Content-Disposition: inline In-Reply-To: <20190808123655.31520-1-stefan@agner.ch> X-Cookie: I think we're in trouble. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/unnNtmY43mpUSKx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 08, 2019 at 02:36:55PM +0200, Stefan Agner wrote: > From: Stefan Agner >=20 > Deferred probes shouldn't cause error messages in the boot log. Avoid > printing with dev_err() in case EPROBE_DEFER is the return value. No, they absolutely should tell the user why they are deferring so the user has some information to go on when they're trying to figure out why their device isn't instantiating. --/unnNtmY43mpUSKx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1MGTQACgkQJNaLcl1U h9AZOgf/ec4pDTD4WicmfgDb6XwsH4eD1aXoxrGSnAB5x5OCvTtls7jFlVUGSmQx J9Ymtb5GfHoT9di2uTZimz1Pj8K97ahY3Ov4Tebl6pinVRZh9cH7j0L03gaxRDQP EEVUkju6pq09n9JR8B2F6iIvoZb6YPRZcuOlZInlbwuW+S1hk25rmGvenhsryxgD JytTBgBlByqutRVIPLSFI1MDLgyGoF5BtgAqqiCP+wccGpa5vSsfpdOY9lPkA/Dz 1J8RvlsWkcJg4Q/YPBAA96CS5IwlX2Cf2EVOs02vTFIldoZub8j/ZMSfhAJhNph8 pUWXwAmBMFjCoV9IoS4b5XlmBjq1Vw== =Ire8 -----END PGP SIGNATURE----- --/unnNtmY43mpUSKx--