Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp6789769ybh; Thu, 8 Aug 2019 05:46:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCEGCMMmmhFfsgib6qNo8L7Z+CTsVH88ElwMQtzFDd7+VPMpzEFf1aSdVmQrGjpNK0EfAL X-Received: by 2002:a17:902:f301:: with SMTP id gb1mr13345713plb.292.1565268395620; Thu, 08 Aug 2019 05:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565268395; cv=none; d=google.com; s=arc-20160816; b=XsJP+FDuXBfvxJuvBpJeZ3IQmWHc89CNXrM65LTpCCKUSLjSSumlR2p5B9U5IvV17m U9qFl8B7xDqhvUzq6HnFo6iJYcLKz6AEnxwVCAtvuGN9KZiZ3Q6kPaekcXqG/DeSURmZ Sz5cIKnXvXk0EfTuRvOca5dVpJsBunoAJW86IhAJdAnNF+kccf3hYrruCfL5O9yZt0Kp 2LkdLYjPhK99u38YocmEX68pnNSJJl9bIk7fQ3+O9VHU3UlPiJ8EnarayMgzWci/VAsE rXstGhlQGj54ZMjQrA/qx7EcRDCBetU2sVF3NHkgtrrdzierSv3dT4FlX78stIlTuRAe QNIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=tQnmKYRVKpyexY0xGtzX+HlHVBQYgzeXikP6GtovUuY=; b=lmod93zGfyOB+lGHTpWL0kA6jlqdhwKPTyh84hN+q8OpZZ+M9F/823kpiihvdKZmq0 StPIhVaa/RTRsc2S7yjRLM7xMiFBNwjEBtngevETofkogfVKP3UmnoPH2bZGHlKX2/lb y4X+PAZ7evK2DX02t1p1I8DnxJxzA/atfyGEOUGlldDfcFGPOFAK3psSslicrPv7SCbO STQauhhMQ2GxS+PP51vWCWWay5PsNBCNGqaZ+vpZEJCx/ibM09CwdfdQyP3y5okiJ0RW 99IEHELNBpMR3iUnJAAqisYhCj2dywuV+So1t+e6aqMTant0ThPUAqknaQSeJnrYoShu 055g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s101si1868370pjc.5.2019.08.08.05.46.19; Thu, 08 Aug 2019 05:46:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732609AbfHHMo5 (ORCPT + 99 others); Thu, 8 Aug 2019 08:44:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59978 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728964AbfHHMo4 (ORCPT ); Thu, 8 Aug 2019 08:44:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DCF56316E536; Thu, 8 Aug 2019 12:44:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D27B55B69A; Thu, 8 Aug 2019 12:44:55 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B870024F30; Thu, 8 Aug 2019 12:44:55 +0000 (UTC) Date: Thu, 8 Aug 2019 08:44:55 -0400 (EDT) From: Pankaj Gupta To: Greg KH Cc: amit@kernel.org, mst@redhat.com, arnd@arndb.de, virtualization@lists.linux-foundation.org, jasowang@redhat.com, linux-kernel@vger.kernel.org Message-ID: <845593916.7427317.1565268295376.JavaMail.zimbra@redhat.com> In-Reply-To: <20190808124232.GA32144@kroah.com> References: <20190808113606.19504-1-pagupta@redhat.com> <20190808113606.19504-3-pagupta@redhat.com> <20190808115630.GB2015@kroah.com> <1512438873.7425183.1565267326035.JavaMail.zimbra@redhat.com> <20190808124232.GA32144@kroah.com> Subject: Re: [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.116.132, 10.4.195.2] Thread-Topic: virtio_ring: packed ring: fix virtqueue_detach_unused_buf Thread-Index: X9W6BkL4XixQLAtInU+7HudXiIE/mA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 08 Aug 2019 12:44:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thu, Aug 08, 2019 at 08:28:46AM -0400, Pankaj Gupta wrote: > > > > > > > > This patch makes packed ring code compatible with split ring in > > > > function > > > > 'virtqueue_detach_unused_buf_*'. > > > > > > What does that mean? What does this "fix"? > > > > Patch 1 frees the buffers When a port is unplugged from the virtio > > console device. It does this with the help of > > 'virtqueue_detach_unused_buf_split/packed' > > function. For split ring case, corresponding function decrements avail ring > > index. > > For packed ring code, this functionality is not available, so this patch > > adds the > > required support and hence help to remove the unused buffer completely. > > Explain all of this in great detail in the changelog comment. What you > have in there today does not make any sense. Sure. Will try to put in more clear words. Thanks, Pankaj > > thanks, > > greg k-h >