Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 08 Aug 2019 15:00:06 +0200
Message-ID: <s5hlfw3izhl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Mark Brown" <broonie@kernel.org>
Cc:     "Stefan Agner" <stefan@agner.ch>, <alsa-devel@alsa-project.org>,
        <lgirdwood@gmail.com>, <perex@perex.cz>,
        "Stefan Agner" <stefan.agner@toradex.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: soc-core: remove error due to probe deferral
In-Reply-To: <20190808124437.GD3795@sirena.co.uk>
References: <20190808123655.31520-1-stefan@agner.ch>
        <20190808124437.GD3795@sirena.co.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 08 Aug 2019 14:44:37 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 08, 2019 at 02:36:55PM +0200, Stefan Agner wrote:
> > From: Stefan Agner <stefan.agner@toradex.com>
> > 
> > Deferred probes shouldn't cause error messages in the boot log. Avoid
> > printing with dev_err() in case EPROBE_DEFER is the return value.
> 
> No, they absolutely should tell the user why they are deferring so the
> user has some information to go on when they're trying to figure out why
> their device isn't instantiating.

But it's no real error that *must* be printed on the console, either.
Maybe downgrading the printk level?


thanks,

Takashi