Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] fs/splice.c: Fix old documentation about moving
 pages
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>
Date:   Thu, 08 Aug 2019 15:19:41 -0300
In-Reply-To: <20190801223852.16042-1-leonardo@linux.ibm.com>
References: <20190801223852.16042-1-leonardo@linux.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-yWqOe3H3Bx7NH7P7c4Zo"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Message-Id: <52a42a7ab5052c7d35c98bca6439ff00e323a947.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-yWqOe3H3Bx7NH7P7c4Zo
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2019-08-01 at 19:38 -0300, Leonardo Bras wrote:
> Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007),
> the SPLICE_F_MOVE support was removed (became a no-op according
> to man pages), and thus disabling steal operation that would make
> moving pages possible.
>=20
> This fixes the comment, making clear pages are not moved.
>=20
> Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> ---
>  fs/splice.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/fs/splice.c b/fs/splice.c
> index 14cb602d9a2f..0ba151c40cef 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe=
, struct file *out,
>   * @flags:	splice modifier flags
>   *
>   * Description:
> - *    Will either move or copy pages (determined by @flags options) from
> - *    the given pipe inode to the given file.
> + *    Will copy pages from the given pipe inode to the given file.
>   *    This one is ->write_iter-based.
>   *
>   */

Could you give any feedback on this patch?

--=-yWqOe3H3Bx7NH7P7c4Zo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl1MZ70ACgkQlQYWtz9S
ttSKCxAAyVy9d2MaMh99ZvG+CtSZa9O3lImfsXKdkkin/kiZnObUGQn6/LhWZT7u
VY1S7c+obycYe9muQ5WSH1F0bLDdbDl0vtkL2NMIuh7ippvU6YjMfm4cEgcZzHzD
sn4T/IJzYy5bA6r3Q/zPey+VKx8JQ7Wc1g9B0YmDD0xhSy3Q65rwv81HDuSwV95c
Tf9YULStVY+q+4dnCBcN66wGWu2g/LYpDwJWFTkL2hWYAMBKCi/B28qn67OLIiQs
05C5QAxkirb9PKvHGg1aobs5rYUEv3xUMPev2ByCLdRFcR5nUDTXjYgQHIqGCCD0
AcIOYQNr6u1ULvUr+63S8BTFD1N/eNenzKFXDS5uFCr2hcCsJDqHA/KTcbW4Rxpg
FqT/q9I59DTJHBCaa5rMzMHWNgQOeiG+vUA718QGmaGSjB0YVp5CaEMkleiL+npE
qOlXASccDgUqc9XpP3fMSF3BkJfvmxG85c5tDC9QCjacLPntKq1zdKQRECiBiuzF
q4MX+AkjRNNZJgmPep3G7IaPUkaQ6IVRyc8ZPX8YwPCz+A5wk1PJP5W6pcguhBub
fgSDBDo1+YQeRkLyDe/nQ45fDRju+9ugXsUaUdjopPGw96/aTe/Dl92VbnkOuT0B
eyU9BEEpliDnxxv4rDvG3feLRxuQv01VRzM6mJssRywRO0KaGQM=
=EBCJ
-----END PGP SIGNATURE-----

--=-yWqOe3H3Bx7NH7P7c4Zo--