Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6ce7545a7a83e8d92fe09110b7f47de7068262fe.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] block: Use bits.h macros to improve readability
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc:     Dennis Zhou <dennis@kernel.org>, Hannes Reinecke <hare@suse.com>,
        Damien Le Moal <damien.lemoal@wdc.com>,
        Tejun Heo <tj@kernel.org>,
        "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>
Date:   Thu, 08 Aug 2019 15:35:11 -0300
In-Reply-To: <a41b5530-f2e1-0932-1f39-0ce66ce902ae@kernel.dk>
References: <20190802000041.24513-1-leonardo@linux.ibm.com>
         <a41b5530-f2e1-0932-1f39-0ce66ce902ae@kernel.dk>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-jW/MQpPut0s05Z/ZdqZw"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-jW/MQpPut0s05Z/ZdqZw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2019-08-02 at 21:18 -0700, Jens Axboe wrote:
> On 8/1/19 6:00 PM, Leonardo Bras wrote:
> > Applies some bits.h macros in order to improve readability of
> > linux/blk_types.h.
> >=20
> > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> > ---
> >   include/linux/blk_types.h | 55 ++++++++++++++++++++------------------=
-
> >   1 file changed, 28 insertions(+), 27 deletions(-)
> >=20
> > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> > index 95202f80676c..31c8c6d274f6 100644
> > --- a/include/linux/blk_types.h
> > +++ b/include/linux/blk_types.h
> > @@ -9,6 +9,7 @@
> >   #include <linux/types.h>
> >   #include <linux/bvec.h>
> >   #include <linux/ktime.h>
> > +#include <linux/bits.h>
> >  =20
> >   struct bio_set;
> >   struct bio;
> > @@ -101,13 +102,13 @@ static inline bool blk_path_error(blk_status_t er=
ror)
> >   #define BIO_ISSUE_SIZE_BITS     12
> >   #define BIO_ISSUE_RES_SHIFT     (64 - BIO_ISSUE_RES_BITS)
> >   #define BIO_ISSUE_SIZE_SHIFT    (BIO_ISSUE_RES_SHIFT - BIO_ISSUE_SIZE=
_BITS)
> > -#define BIO_ISSUE_TIME_MASK     ((1ULL << BIO_ISSUE_SIZE_SHIFT) - 1)
> > +#define BIO_ISSUE_TIME_MASK     GENMASK_ULL(BIO_ISSUE_SIZE_SHIFT - 1, =
0)
>=20
> Not sure why we even have these helpers, I'd argue that patches like
> this HURT readability, not improve it. When I see
>=20
> ((1ULL << SOME_SHIFT) - 1)
>=20
> I know precisely what that does, whereas I have to think about the other
> one, maybe even look it up to be sure. For instance, without looking
> now, I have no idea what the second argument is. Looking at the git log,
> I see numerous instances of:
>=20
> "xxx: Fix misuses of GENMASK macro
>=20
>  Arguments are supposed to be ordered high then low."
>=20
> Hence it seems GENMASK_ULL is easy to misuse or get wrong, the very
> opposite of what you'd want in a helper. How is it helping readability
> if the helper is easy to misuse?
>=20
> Ditto with
>=20
> (1ULL << SOME_SHIFT)
>=20
> vs BIT_ULL. But at least that one doesn't have a mysterious 2nd
> argument.
>=20
> Hence I'm not inclined to apply this patch.
>=20

Well, as a newbie, macros like GENMASK(a,b) look way simpler. I to read
than (((1 << a) - 1) << b), or (~((1 << c) - 1)).
I mean, in GENMASK all bits >=3D a, <=3Db are set.=20

But I agree that once you get used to reading masks created with <<, it
doesn't look that harder.

Well, thanks for this feedback.

Regards,=20
Leonardo Br=C3=A1s

--=-jW/MQpPut0s05Z/ZdqZw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl1Ma18ACgkQlQYWtz9S
ttTe9hAAjhtl35pbIXslE/8abzIr6IPh4aKByZWmQGSyN+6XVatGy7ScXCRCKT39
0Gq2Xh/DTSJYrSUYEKlYuz8enNxuJpl7H7hFoP5tabUlr8eOxYPH0IirduYuCDvx
in5iJU/62UBGxcANhyFWD2MFoEcPPSATI+dUAHr1Uq9vGlVOXWW21JDRe48Q8VbI
UsRw29RHBJDzqq7tHX811nkn8Pv8e/iMaD6KheD87IdIwdSscmRpORc+nOdUH9t1
dsp7h4KhRlcpl+IAwmGf4bhy0aWvr2VuwYE6tSPYa1BgUeg29q0Cd4pXt6a03BLT
eNOKiz5RXY06aTpUW+CcfvhooKWEWdxjVpzRpdjXcnp+rYQ4tmsrSyyofRBgjet4
9DrQCelgHBwPynqs0BSvwwP66yiSjQR1aRmu/SoykSqdhehhGqm4qWtJnRhJd5DH
gr8/f43rFec8Ms5Fo9IOMzLjA331MVHwPhuW4j54FH5cM3DSuKx4AcWj53aEuqCH
cJF+IhkmHbnA1N12bmY3zX24gCm+G2OdhrlkuxecN3IyUyk7hH30gwofM55HXpRH
xwbPLkQlzlaaiqTbP9XsjhPwfyjvg6DCFEgu7Ip4TrGOJlDmWUrc/VYWld+XaBoa
eJX1+6ioGpy7kHgeSk8Xhp3sHa9cHR8MTFYvPpog1kfFzTmX86M=
=f8ZH
-----END PGP SIGNATURE-----

--=-jW/MQpPut0s05Z/ZdqZw--