Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp7214097ybh; Thu, 8 Aug 2019 11:56:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoFmcOb8U1Nsajlb2KX7fb38XzAXZz68rcFf7BU0d0fmuDbi2H5oGjlMcqiEvuv5CJBv7y X-Received: by 2002:a17:90a:e397:: with SMTP id b23mr5511317pjz.117.1565290614485; Thu, 08 Aug 2019 11:56:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565290614; cv=none; d=google.com; s=arc-20160816; b=EvrOfONu0xisyE1RIVk7lroj9lgdQ/GG9AWsFikqLSjeg+FLr99Noc383NT40fqVBB 8CQUfrbCCZOJERbTVvriI+pil6ZwX56854brx/Cj5teHaGfirDo3G5zy+q0zkPvQgJyG c8ktUphxc15xMjDxznwWngGtQqYTcPccjRy5oj47vqY21Lydmg1jAiVToRLX9kZ0/ddm 3QwhWWozcEIaIeXIbvSjS+a8pAUk6U9cjJAbFjthMFu8dpX7/uxbBeqkHRU5NUgxNuBz KP0wnTh7oOh/EqS2ITwGRGBr1b4uJMUhKRim9AUBLY7V2KuYdeI6yb/QFih3HAYyLvqu v78Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QjkoBON2R0G9dPWiD46toYdQm9FG0fge33xVSCag5ms=; b=UNVJxTGJG+KooknS54kfMND9fSHBJmD+/HP3N6aKaR/Fw/6hOO3XIB3ysorSb+q3AM V+p5SNJD9ZV+3l3WOHxZVp3tCFO97WEDZadh1j+Gc2h6rmev0GMflQWFq4HPZYHvBAvz Y4lwFRbMFIkpcg2/QQFJ1uqt+jPJHymupRtfbXsPPJP6FU9fncJDMHJDFpPBgpgSB4Ei NTrToQRqXXCWaHuY5SvDIqhC7HiUCGfZur44yBIizAOedOEpFKazinMO+T5E389yoTTa xJzJMnOGKcr5KVvMsqIpa5PS82uu/MGfBW/u+tJSc6mQY6wgTyUElpQ7BKfjqwAs2nJP ZFrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vqt03qIK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3si50646641pgn.467.2019.08.08.11.56.39; Thu, 08 Aug 2019 11:56:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vqt03qIK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404204AbfHHSze (ORCPT + 99 others); Thu, 8 Aug 2019 14:55:34 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35066 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404161AbfHHSzd (ORCPT ); Thu, 8 Aug 2019 14:55:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QjkoBON2R0G9dPWiD46toYdQm9FG0fge33xVSCag5ms=; b=vqt03qIKNSYXmWRwtn6SMC0vn 2KxAD407l3Awcyh2IzdII6GyPqRZFsRiCPW6czfrc9RB9mRifazXgV+8/2TNZ76/UaOA0+A2UJDmJ IyNQtmNyWKwRuBMlsGkSPrg8Pj0jKAk8CeSe2LXRN+1EW53APKC59dZ9Blp6kqbrQuQNw=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hvnZL-0003lN-Gm; Thu, 08 Aug 2019 18:55:23 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 5CB972742B42; Thu, 8 Aug 2019 19:55:22 +0100 (BST) Date: Thu, 8 Aug 2019 19:55:22 +0100 From: Mark Brown To: Tomer Maimon Cc: Rob Herring , Mark Rutland , Vignesh Raghavendra , bbrezillon@kernel.org, Avi Fishman , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , linux-spi@vger.kernel.org, devicetree , OpenBMC Maillist , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver Message-ID: <20190808185522.GJ3795@sirena.co.uk> References: <20190808131448.349161-1-tmaimon77@gmail.com> <20190808131448.349161-3-tmaimon77@gmail.com> <20190808132740.GG3795@sirena.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5me2qT3T17SWzdxI" Content-Disposition: inline In-Reply-To: X-Cookie: I think we're in trouble. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5me2qT3T17SWzdxI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 08, 2019 at 06:37:06PM +0300, Tomer Maimon wrote: > for example in our driver we modify the access type (singe, dual or quad) > according the op->addr.buswidth > for example in the npcm_fiu_set_drd function. > regmap_update_bits(fiu->regmap, NPCM_FIU_DRD_CFG, > NPCM_FIU_DRD_CFG_ACCTYPE, > ilog2(op->addr.buswidth) << > NPCM_FIU_DRD_ACCTYPE_SHIFT); > we also modify it in the UMA R/W functions. Ah, it's only for the flash functions - that's fine. --5me2qT3T17SWzdxI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1McBkACgkQJNaLcl1U h9CSyQf9HMQyWI7F+/mz/TefzbACHnpE0c8lwToPC8gs3NlHo8g0orLblfG3DsLm UEB893DEnNq2PyAZ3RalNBeet13paLEA0qBru8OSMUWpeNwDNxNPJnw0LKgWMfJd hR7ajSCzI8nNleQRxNko7depUDzpemRXDWxmIyeoBPOYzHxX3AWFoyuaz9aUo2Rl Unh0Hf1osxqIy1e/McvePEnPv0TT99Ymj8k6/8GnvioyP4EpahOXI8dSR2jI0EhD E00zLhgmAoNpkwrV/jtjy/U4bWl2oEXrySbQ9Ljy8b0iFVArSIEFILHO06iXOkXP gKzJeeqWsQ6fz//+fGxegx1F6fcTpg== =AZer -----END PGP SIGNATURE----- --5me2qT3T17SWzdxI--